-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[development] Adding generic, maven based run and debug. #2435
Conversation
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Also see openhab/openhab-distro#1707 Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the amount of work you put into that! Take the review comments as an appreciation of the work. I did at least try out every step you wrote in generic.md and it worked out of the box! 🎉
In the beginning I was actually not finding that page and therefore I wonder if we should not add all IDE pages as subpages to the menu? (this can be done in docs-sidebar.js)
- mvn clean install in the root of `<ADDON_DIR>` using commandline Maven (or IntelliJ Maven view) | ||
- some of the add-ons might fail to build - if it's not the one, you're interested in that should not bother you | ||
- when the Maven project finished, you should find the freshly built addon JAR in the target directory | ||
This is the simpler option, but you can only use it for add-on development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should link to the generic page here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it, which generic page ?
In the line you cite, the "simpler option" mentionned is described just after (it's the 'old' way : just copy the addon jar in the addon directory)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
developers/ide/generic.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generic page is the option 2 section, and it already has a link.
Many thanks for your wise suggestions ! |
32aa45d
to
c1f183b
Compare
I 100% agree with you. I added it, tell me what you think. |
Apply MR comments Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Apply MR comments Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Seems good to me now. Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalgwen for your effort! LGTM.
Many thanks for these awesome docs @dalgwen! |
With openhab/openhab-distro#1707
It is now possible to run the demo project with maven in a generic, non-ide related way.
All IDE can then leverage this to debug any openHAB component (core included).
I also made some modification to IntelliJ to use this.