Fix marketplace add-on services fail after upgrade #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A format change in the database (related to the introduction of addon.xml) leads to a non-migrateable and permanent error that floods the log with exceptions and malfunctions. If such an error is detected, the database is purged and an error logged. Signed-off-by: Jan N. Klug <github@klug.nrw>
jlaur
reviewed
Apr 27, 2023
| .forEach(addons::add); | ||
| } catch (JsonSyntaxException e) { | ||
| List.copyOf(installedAddonStorage.getKeys()).forEach(installedAddonStorage::remove); | ||
| logger.error( |
There was a problem hiding this comment.
Perhaps it would be useful to also log the removed entries?
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
@kaikreuzer For better user-experience this should also be merged before M3. |
kaikreuzer
approved these changes
May 13, 2023
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Fix marketplace add-on services fail after upgrade A format change in the database (related to the introduction of addon.xml) leads to a non-migrateable and permanent error that floods the log with exceptions and malfunctions. If such an error is detected, the database is purged and an error logged. Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 55d6d21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A format change in the database (related to the introduction of addon.xml) leads to a non-migrateable and permanent error that floods the log with exceptions and malfunctions.
If such an error is detected, the database is purged and an error logged.
Also reported on the forum several times.