Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ConfigValidationMessage in ThingManagerImpl #3474

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Fix ConfigValidationMessage in ThingManagerImpl #3474

merged 1 commit into from
Mar 24, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Mar 22, 2023

Seen in the message in #3473: The placeholder was not properly replaced.

@J-N-K
Fix ConvigValidationMessage in ThingManagerImpl
1803a16 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Mar 22, 2023
@J-N-K J-N-K requested a review from a team as a code owner March 22, 2023 20:08
cweitkamp
cweitkamp approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit 8494bf1 into openhab:main Mar 24, 2023
@cweitkamp cweitkamp added this to the 4.0 milestone Mar 24, 2023
@J-N-K J-N-K deleted the bug-configvalidation branch March 24, 2023 09:15
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@J-N-K @splatch
[config] Fix ConvigValidationMessage in ThingManagerImpl (openhab#3474)
ff582c4 
Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 8494bf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@J-N-K @cweitkamp