Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log levels and duplicate implementation warning in tests #2982

Merged
merged 2 commits into from
May 26, 2022
Merged

Fix log levels and duplicate implementation warning in tests #2982

merged 2 commits into from
May 26, 2022

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented May 26, 2022

Related to #2939

Needed to solve issues in openhab-addons

Signed-off-by: Jan N. Klug github@klug.nrw

@J-N-K
Fix log levels and duplicate implementation warning in tests
7310eb2 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label May 26, 2022
@J-N-K J-N-K requested a review from a team as a code owner May 26, 2022 16:54
@J-N-K J-N-K added infrastructure and removed enhancement An enhancement or new feature of the Core labels May 26, 2022
@J-N-K
fix for org.openhab.core bundle, too
995307c 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K mentioned this pull request May 26, 2022
Merged
wborn
wborn approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 344a9ae into openhab:main May 26, 2022
@wborn wborn added this to the 3.3 milestone May 26, 2022
@J-N-K J-N-K deleted the branch-2 branch May 26, 2022 21:35
@jlaur jlaur mentioned this pull request May 27, 2022
Merged
@jlaur
Copy link
Contributor

jlaur commented Jul 20, 2022

@J-N-K - I have noticed recently that when compiling the miele add-on, this SAT warning is generated 18 times:

[WARNING] Error during type resolution of field 'Mock' in class org.openhab.core.test.java.JavaTest due to: java.lang.NoClassDefFoundError: ch/qos/logback/core/Appender

It seems related - do you know how to mitigate this?

@J-N-K
Copy link
Member Author

J-N-K commented Jul 20, 2022

It seems that a dependency is missing somewhere. I'll check that.

@J-N-K J-N-K mentioned this pull request Jul 20, 2022
Merged
marcelrv added a commit to marcelrv/openhab-addons that referenced this pull request Jan 9, 2023
@marcelrv
[miio] fix logging in test folder
ad468cd 
Brings back the log messages for o.a. ReadmeHelper that disappeared due
to openhab/openhab-core#2982

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv mentioned this pull request Jan 9, 2023
Open
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@J-N-K @splatch
Fix log levels and duplicate implementation warning in tests (openhab…
fd86a7c 
…#2982)

* Fix log levels and duplicate implementation warning in tests

Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 344a9ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@J-N-K @jlaur @wborn