Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] fix channels with invalid names #9888

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

marcelrv
Copy link
Contributor

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

note: some misc sorting changes in the purifier done by my validator as well

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv added the bug An unexpected problem or unintended behavior of an add-on label Jan 20, 2021
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 21, 2021
@marcelrv marcelrv linked an issue Jan 21, 2021 that may be closed by this pull request
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 23fd13c into openhab:main Jan 22, 2021
@cpmeister cpmeister added this to the 3.1 milestone Jan 22, 2021
@marcelrv marcelrv deleted the miio-channelFix branch January 22, 2021 10:02
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
* [miio] fix channels with invalid names
* [miio] allow for readbale friendly names

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* [miio] fix channels with invalid names
* [miio] allow for readbale friendly names

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* [miio] fix channels with invalid names
* [miio] allow for readbale friendly names

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[miio] Xiaomi Binding - Air Purifier MB3
3 participants