Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[siemensrds] Hide already instantiated Things in the InBox #9808

Merged
merged 2 commits into from
Jan 13, 2021
Merged

[siemensrds] Hide already instantiated Things in the InBox #9808

merged 2 commits into from
Jan 13, 2021

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Jan 12, 2021 •
edited
Loading

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Added Representation Property so that already instantiated Things will be hidden in the InBox.

Also fixed a potential null pointer issue.

@andrewfg
[siemensrds] null value check
8fda9a6 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[siemensrds] representation property
780952a 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg added enhancement An enhancement or new feature for an existing add-on rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 12, 2021
@andrewfg andrewfg requested a review from kaikreuzer January 13, 2021 16:32
@cpmeister cpmeister merged commit 18d06bb into openhab:main Jan 13, 2021
@cpmeister cpmeister added this to the 3.1 milestone Jan 13, 2021
@andrewfg andrewfg deleted the siemensrds-rep-prop branch March 30, 2021 14:25
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@andrewfg @themillhousegroup
[siemensrds] Hide already instantiated Things in the InBox (openhab#9808
4f0aa3c 
)

* [siemensrds] null value check
* [siemensrds] representation property

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@andrewfg @thinkingstone
[siemensrds] Hide already instantiated Things in the InBox (openhab#9808
283a844 
)

* [siemensrds] null value check
* [siemensrds] representation property

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@andrewfg
[siemensrds] Hide already instantiated Things in the InBox (openhab#9808
2c2c1e4 
)

* [siemensrds] null value check
* [siemensrds] representation property

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewfg @cpmeister