[tesla] Correctly handle floating point numbers for estimatedbatteryrange channel #9802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
bug
cweitkamp
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
LGTM. Thanks.
The issue and its fix are looking similar to my PRs (#9596 for Chromecast and #9597 for Kodi). I am wondering if we should add a general fix in the SseItemStatesEventBuilder like we have in the ItemUIRegistryImpl which replaces "%d" by "%.0f" in general.
kaikreuzer
added a commit
that referenced
this pull request
Mar 2, 2021
Fixes #9636 Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
patch
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
Fixes openhab#9636 Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Fixes openhab#9636 Signed-off-by: Kai Kreuzer <kai@openhab.org>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Fixes openhab#9636 Signed-off-by: Kai Kreuzer <kai@openhab.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9636
Signed-off-by: Kai Kreuzer kai@openhab.org