Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pidcontroller] Initial Contribution #9512

Merged
merged 2 commits into from
Dec 28, 2020
Merged

[pidcontroller] Initial Contribution #9512

merged 2 commits into from
Dec 28, 2020

Conversation

fwolter
Copy link
Member

@fwolter fwolter commented Dec 25, 2020 •
edited
Loading

This is a PID controller for openHAB.

The implementation is based on the work of @george.erhan (forum) and @Hilbrand.

See https://community.openhab.org/t/new-automation-pid-controller/111229

@fwolter
[pidcontroller] Initial Contribution
88c73a1 
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
@fwolter fwolter requested a review from a team December 25, 2020 08:03
J-N-K
J-N-K requested changes Dec 25, 2020
View reviewed changes
bundles/org.openhab.automation.pidcontroller/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.automation.pidcontroller/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.automation.pidcontroller/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.automation.pidcontroller/README.md Outdated Show resolved Hide resolved
...n/java/org/openhab/automation/pidcontroller/internal/handler/PIDControllerActionHandler.java Outdated Show resolved Hide resolved
...va/org/openhab/automation/pidcontroller/internal/template/PIDControllerTemplateProvider.java Outdated Show resolved Hide resolved
...va/org/openhab/automation/pidcontroller/internal/template/PIDControllerTemplateProvider.java Outdated Show resolved Hide resolved
...va/org/openhab/automation/pidcontroller/internal/template/PIDControllerTemplateProvider.java Outdated Show resolved Hide resolved
...va/org/openhab/automation/pidcontroller/internal/template/PIDControllerTemplateProvider.java Outdated Show resolved Hide resolved
...java/org/openhab/automation/pidcontroller/internal/type/PIDControllerModuleTypeProvider.java Outdated Show resolved Hide resolved
@fwolter
Incorporate review feedback No.1
1d6ce3e 
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
@fwolter
Copy link
Member Author

fwolter commented Dec 25, 2020

@J-N-K Thanks! I incorporated all your feedback.

J-N-K
J-N-K approved these changes Dec 27, 2020
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cpmeister
cpmeister approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 924eca2 into openhab:main Dec 28, 2020
@cpmeister cpmeister added this to the 3.1 milestone Dec 28, 2020
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
@fwolter @seaside1
[pidcontroller] Initial Contribution (openhab#9512)
fc6c9a9 
* [pidcontroller] Initial Contribution
* Incorporate review feedback No.1

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
@fwolter @seaside1
[pidcontroller] Initial Contribution (openhab#9512)
2c4b1dd 
* [pidcontroller] Initial Contribution
* Incorporate review feedback No.1

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
@Hilbrand Hilbrand mentioned this pull request Jan 2, 2021
Closed
@m0rgano
Copy link

m0rgano commented Jan 4, 2021

@fwolter
Great news to find your work on this.
Is there any documentation on how to install and/or use it?
I am currently using V2.5 - is it compatible with this version?

@fwolter
Copy link
Member Author

fwolter commented Jan 4, 2021

You find the documentation here /~https://github.com/fwolter/openhab-addons/blob/pidcontroller/bundles/org.openhab.automation.pidcontroller/README.md

You need OH 3.x to run it.

@fwolter fwolter deleted the pidcontroller branch January 4, 2021 12:31
@m0rgano
Copy link

m0rgano commented Jan 4, 2021

@fwolter
Thanks for the link Fabian - unfortunately I get a 404 error on it.

@fwolter
Copy link
Member Author

fwolter commented Jan 4, 2021

Ha, that's why I just deleted the dev branch. Here is the link to the merged version: /~https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.automation.pidcontroller/README.md

@m0rgano
Copy link

m0rgano commented Jan 4, 2021

@fwolter That link is working OK thanks. I'm familiar with the Rules engine - I have a lot of text-based rules.
Do you have a simple rule example you could paste here showing the use of the PID addon to get me (and others) started please?

@fwolter
Copy link
Member Author

fwolter commented Jan 4, 2021

I have no clue how to configure it text-based. The forum post linked in the initial message shows screenshots of an UI based configuration.

@m0rgano
Copy link

m0rgano commented Jan 4, 2021

@fwolter OK thanks - I'll ask in the OH thread if it is possible via the Rules DSL or whether it has to be in the GUI.

thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@fwolter @thinkingstone
[pidcontroller] Initial Contribution (openhab#9512)
cd4b48f 
* [pidcontroller] Initial Contribution
* Incorporate review feedback No.1

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@fwolter
[pidcontroller] Initial Contribution (openhab#9512)
4c4720d 
* [pidcontroller] Initial Contribution
* Incorporate review feedback No.1

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
new automation
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@fwolter @m0rgano @cpmeister @J-N-K