Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] Fix blu gateway script to prevent crash #16371

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

markus7017
Copy link
Contributor

@markus7017 markus7017 commented Feb 4, 2024

Hotfix to avoid a crash on the blue gateway script when receiving unknown properties
Please consider backport to 4.1

Closing
#16370

Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 added the bug An unexpected problem or unintended behavior of an add-on label Feb 4, 2024
@markus7017 markus7017 self-assigned this Feb 4, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM
Double check before i backport this, is this properly tested?

@ErikDB87
Copy link
Contributor

ErikDB87 commented Feb 5, 2024

Code LGTM
Double check before i backport this, is this properly tested?

I don't know whether it counts as 'properly' testing, but I've been running this script successfully (i.e. without it breaking) since Wednesday. Before the fix, it broke after 2 hours.

@lsiepel lsiepel merged commit 970b4d3 into openhab:main Feb 5, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Feb 5, 2024
lsiepel pushed a commit that referenced this pull request Feb 5, 2024
Signed-off-by: Markus Michels <markus7017@gmail.com>
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Feb 5, 2024
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
3 participants