-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hydrawise] Fixes occasional connection issues #15177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing service outages, like when they are updating thier software. This treats this as a connection error and allows the client to try the poll again. Fixes openhab#15170 Signed-off-by: Dan Cunningham <dan@digitaldan.com>
jlaur
requested changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Only one comment for consideration as further improvement.
...src/main/java/org/openhab/binding/hydrawise/internal/api/graphql/HydrawiseGraphQLClient.java
Show resolved
Hide resolved
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
jlaur
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks as always @jlaur ! |
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Jul 8, 2023
* The Hydrawise API can return sometimes return a non JSON response during service outages, like when they are updating thier software. This treats this as a connection error and allows the client to try the poll again. * Adds additional http status checking Fixes openhab#15170 Signed-off-by: Dan Cunningham <dan@digitaldan.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
* The Hydrawise API can return sometimes return a non JSON response during service outages, like when they are updating thier software. This treats this as a connection error and allows the client to try the poll again. * Adds additional http status checking Fixes openhab#15170 Signed-off-by: Dan Cunningham <dan@digitaldan.com> Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* The Hydrawise API can return sometimes return a non JSON response during service outages, like when they are updating thier software. This treats this as a connection error and allows the client to try the poll again. * Adds additional http status checking Fixes openhab#15170 Signed-off-by: Dan Cunningham <dan@digitaldan.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hydrawise API can return sometimes return a non JSON response during service outages, like when they are updating their software. This treats this as a connection error and allows the client to try the poll again.
Fixes #15170