Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hydrawise] Fixes occasional connection issues #15177

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

digitaldan
Copy link
Contributor

The Hydrawise API can return sometimes return a non JSON response during service outages, like when they are updating their software. This treats this as a connection error and allows the client to try the poll again.

Fixes #15170

…ing service outages, like when they are updating thier software. This treats this as a connection error and allows the client to try the poll again.

Fixes openhab#15170

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Only one comment for consideration as further improvement.

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jul 4, 2023
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit d830848 into openhab:main Jul 4, 2023
@jlaur jlaur added this to the 4.0 milestone Jul 4, 2023
@digitaldan
Copy link
Contributor Author

Thanks as always @jlaur !

markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Jul 8, 2023
* The Hydrawise API can return sometimes return a non JSON response during service outages, like when they are updating thier software.  This treats this as a connection error and allows the client to try the poll again.
* Adds additional http status checking

Fixes openhab#15170

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
* The Hydrawise API can return sometimes return a non JSON response during service outages, like when they are updating thier software.  This treats this as a connection error and allows the client to try the poll again.
* Adds additional http status checking

Fixes openhab#15170

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* The Hydrawise API can return sometimes return a non JSON response during service outages, like when they are updating thier software.  This treats this as a connection error and allows the client to try the poll again.
* Adds additional http status checking

Fixes openhab#15170

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hydrawise] Binding stops updating
2 participants