Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imperihome] Remove imperihome addon #15014

Merged
merged 1 commit into from
May 23, 2023

Conversation

holgerfriedrich
Copy link
Member

I remember a discussion with @lolodomo when I applied patches due to core changes to the addon repo.
#14774 (comment)
He pointed out that imperihome binding should be removed, as the service is no longer available.

Does anyone see the need to keep the addon in the repo or can we remove it? If yes, please close my PR. Otherwise we should remove obsolete code.

@lolodomo @pdegeus @openhab/add-ons-maintainers

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich requested review from pdegeus and a team as code owners May 21, 2023 23:04
@holgerfriedrich holgerfriedrich added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels May 22, 2023
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit ac04a4e into openhab:main May 23, 2023
@lolodomo lolodomo added this to the 4.0 milestone May 23, 2023
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label May 23, 2023
@holgerfriedrich holgerfriedrich deleted the pr-imperihome branch May 23, 2023 06:15
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants