Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[danfossairunit] Add UoM support for rotational speed channels #15002

Merged
merged 1 commit into from
May 20, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented May 17, 2023

@jlaur jlaur added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels May 17, 2023
@jlaur jlaur force-pushed the danfossairunit-uom-rpm branch from 9a7588a to f982ce8 Compare May 18, 2023 10:27
@jlaur jlaur removed the awaiting other PR Depends on another PR label May 18, 2023
@jlaur jlaur marked this pull request as ready for review May 18, 2023 11:03
@jlaur jlaur requested a review from pravussum as a code owner May 18, 2023 11:03
@jlaur jlaur requested a review from a team May 18, 2023 11:03
@jlaur jlaur force-pushed the danfossairunit-uom-rpm branch 3 times, most recently from 180a2c8 to 55ff250 Compare May 18, 2023 11:30
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the danfossairunit-uom-rpm branch from 55ff250 to b820415 Compare May 18, 2023 12:11
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit e598a06 into openhab:main May 20, 2023
@lolodomo lolodomo added this to the 4.0 milestone May 20, 2023
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
@jlaur jlaur deleted the danfossairunit-uom-rpm branch August 14, 2023 18:03
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants