Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hue] Fix NullPointerException in NUPnP discovery #14989

Merged
merged 1 commit into from
May 13, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented May 13, 2023

Related to #14871, #14918
Resolves #14852

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label May 13, 2023
@jlaur jlaur requested a review from cweitkamp as a code owner May 13, 2023 19:16
@jlaur jlaur requested a review from a team May 13, 2023 19:19
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/hue-binding-with-added-support-for-api-v2/146648/11

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@jlaur
Copy link
Contributor Author

jlaur commented May 13, 2023

@lolodomo - this should probably be cherry-picked into the 3.4.x branch. If you agree, I can do that.

@lolodomo
Copy link
Contributor

lolodomo commented May 13, 2023

Of course. I let you do.

@lolodomo lolodomo merged commit 939c9ca into openhab:main May 13, 2023
@lolodomo lolodomo added this to the 4.0 milestone May 13, 2023
@jlaur jlaur deleted the 14852-hue-nupnp-fix-npe branch May 13, 2023 19:35
jlaur added a commit that referenced this pull request May 13, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label May 13, 2023
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hue] NUPnP discovery broken
3 participants