Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonos] Add support for Era 100 and Era 300 #14920

Merged
merged 1 commit into from
May 5, 2023
Merged

[sonos] Add support for Era 100 and Era 300 #14920

merged 1 commit into from
May 5, 2023
+166 −14

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented May 1, 2023

Closes #14802

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged labels May 1, 2023
@lolodomo lolodomo requested a review from kgoderis as a code owner May 1, 2023 23:00
@lolodomo
Copy link
Contributor Author

lolodomo commented May 1, 2023

Waiting for information about settings available for these models (bass, treble, loudness, speech enhancement, night mode).
Currently channels for bass, treble and loudness are included but no channels for speech enhancement and night mode.

@lolodomo
[sonos] Add support for Era 100 and Era 300
7785260 
Closes openhab#14802

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the sonos_era_100_300 branch from 810057c to 7785260 Compare May 1, 2023 23:26
jlaur
jlaur requested changes May 2, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating with latest models! Only a minor comment about the unrelated Arc SL product name changes.

bundles/org.openhab.binding.sonos/README.md Show resolved Hide resolved
bundles/org.openhab.binding.sonos/README.md Show resolved Hide resolved
bundles/org.openhab.binding.sonos/README.md Show resolved Hide resolved
jlaur
jlaur approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for signal to merge since still labeled "Work in progress". Will it be tested by a happy owner of an Era speaker?

@lolodomo lolodomo removed enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged labels May 5, 2023
@lolodomo
Copy link
Contributor Author

lolodomo commented May 5, 2023

Waiting for signal to merge

@jlaur : you can merge, I just got information from @dankr3 for era 100 and it is was I guessed.

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label May 5, 2023
@jlaur jlaur merged commit dea24b3 into openhab:main May 5, 2023
@jlaur jlaur added this to the 4.0 milestone May 5, 2023
@lolodomo lolodomo deleted the sonos_era_100_300 branch May 5, 2023 21:11
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
@lolodomo @tburri-alstom
[sonos] Add support for Era 100 and Era 300 (openhab#14920)
149efb3 
Closes openhab#14802

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
@lolodomo @matchews
[sonos] Add support for Era 100 and Era 300 (openhab#14920)
8e0f462 
Closes openhab#14802

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
@jlaur jlaur mentioned this pull request Oct 5, 2023
Closed
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@lolodomo @austvik
[sonos] Add support for Era 100 and Era 300 (openhab#14920)
490a004 
Closes openhab#14802

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[Sonos] 'Sonos Era 100' is not yet a supported model
2 participants
@lolodomo @jlaur