[ipcamera] Fix servlet exceptions due to non unique names #14872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apella12
force-pushed
the
ipcamera-unique-servlet-names
branch
from
5a2c42e to
5f4e4d8
Compare
jlaur
requested changes
Apr 23, 2023
...ng.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/servlet/IpCameraServlet.java
Outdated
Show resolved
Hide resolved
[IP camera] on OH4 has the same servlet issue that was fixed by PR openhab#14554. This PR uses that PR as a template to fix the issue in the IPcamera binding. (That issue being that only one camera was able to stream.) This was tested locally on OH4M2 and it works. Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com> Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com>
apella12
force-pushed
the
ipcamera-unique-servlet-names
branch
from
5f4e4d8 to
dab4bf7
Compare
Tested the suggested changes locally and it still works. Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
) * [ipcamera] Fix servlet exceptions due to non unique names [IP camera] on OH4 has the same servlet issue that was fixed by PR openhab#14554. This PR uses that PR as a template to fix the issue in the IPcamera binding. (That issue being that only one camera was able to stream.) This was tested locally on OH4M2 and it works. Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com> Signed-off-by: Matt Myers <mmyers75@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IP camera] on OH4 has the same servlet issue that was fixed by PR #14554. This PR uses that PR as a template to fix the issue in the IPcamera binding. (That issue being that only one camera was able to stream.) This was tested locally on OH4M2 and it works. Also the referenced PR worked with [neeo] and this used that PR as a template.
Signed-off-by: Bob Eckhoff katmandodo@yahoo.com