[knx] Improve rounding when encoding DPT 232.60000 #14772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
J-N-K
requested changes
Apr 10, 2023
...binding.knx/src/main/java/org/openhab/binding/knx/internal/handler/IPBridgeThingHandler.java
Outdated
Show resolved
Hide resolved
|
Can you fix the DCO? and then force-push. |
holgerfriedrich
force-pushed
the
pr-knx-rounding
branch
from
c2eb9b7 to
2c57b91
Compare
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
force-pushed
the
pr-knx-rounding
branch
from
2c57b91 to
be1e519
Compare
Sure. Sorry. |
|
@holgerfriedrich - does it resolve #12643? |
@jlaur not fully. For me #12643 is a "won't fix". Let me write a comment there. |
|
@J-N-K, @jlaur, @kaikreuzer could you please merge this one? |
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
* [knx] Improve rounding when encoding DPT 232.60000 * [knx] SAT and warnings Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the rounding behavior.
See also openhab/openhab-core#3479.
Refs. #12643
Some additional fixes for compilation and SAT warnings that were recently introduced.