-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Yeelight] Support of ceil26 and ceiling11 devices #14668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandr Salamatov <goopilot@gmail.com>
goopilot
changed the title
Support of ceil26 and ceiling11 devices
[Yeelight] Support of ceil26 and ceiling11 devices
Mar 25, 2023
This was referenced Mar 25, 2023
lolodomo
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Mar 25, 2023
lolodomo
requested changes
Mar 25, 2023
.../src/main/java/org/openhab/binding/yeelight/internal/discovery/YeelightDiscoveryService.java
Show resolved
Hide resolved
...nding.yeelight/src/main/java/org/openhab/binding/yeelight/internal/lib/enums/DeviceType.java
Show resolved
Hide resolved
Signed-off-by: Alexandr Salamatov <goopilot@gmail.com>
lolodomo
requested changes
Mar 26, 2023
Signed-off-by: Alexandr Salamatov <goopilot@gmail.com>
lolodomo
requested changes
Apr 2, 2023
Signed-off-by: Alexandr Salamatov <goopilot@gmail.com>
lolodomo
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
* Support of ceil26 and ceiling11 devices Signed-off-by: Alexandr Salamatov <goopilot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexandr Salamatov goopilot@gmail.com
Added support of a ceiling lights YLXD41YL (ceiling11) and YLXD76YL (ceil26).
Capabilities are same as ceiling1
ceiling1
{'ip': '192.168.112.65', 'port': 55443, 'capabilities': {'id': '0x0000000007e7f54d', 'model': 'ceiling1', 'fw_ver': '193', 'support': 'get_prop set_default set_power toggle set_bright set_scene cron_add cron_get cron_del start_cf stop_cf set_ct_abx set_name set_adjust adjust_bright adjust_ct', 'power': 'on', 'bright': '100', 'color_mode': '2', 'ct': '3500', 'rgb': '0', 'hue': '0', 'sat': '0', 'name': ''}}
ceil26
{'ip': '192.168.112.108', 'port': 55443, 'capabilities': {'id': '0x0000000015627cc9', 'model': 'ceil26', 'fw_ver': '18', 'support': 'get_prop set_default set_power toggle set_bright set_scene cron_add cron_get cron_del start_cf stop_cf set_adjust adjust_bright set_name set_ct_abx adjust_ct', 'power': 'on', 'bright': '100', 'color_mode': '2', 'ct': '3500', 'rgb': '0', 'hue': '0', 'sat': '0', 'name': ''}}
ceiling11
{'ip': '192.168.XXX.YYY', 'port': 55443, 'capabilities': {'hue': '0', 'color_mode': '2', 'name': '', 'power': 'on', 'support': 'get_prop set_default set_power toggle set_bright set_scene cron_add cron_get cron_del start_cf stop_cf set_ct_abx set_name set_adjust adjust_bright adjust_ct', 'rgb': '0', 'fw_ver': '19', 'bright': '66', 'model': 'ceiling11', 'ct': '4000', 'id': '0x000000001234aa56', 'sat': '0'}}
This will close 2 issues: #11246 and #11293