[knx] Remove workaround for DPT 14 #14503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed in Calimero 2.4. Carryover from smarthomej/addons#104. Also-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
|
@J-N-K can I start the carryover for the knx binding? Is the commit message / credit ok for you? I added you to the sign-off using an Also-by statement. Not sure if this is the intended way. Refs: #14502 |
J-N-K
approved these changes
Feb 26, 2023
30 tasks
lolodomo
approved these changes
Feb 26, 2023
lolodomo
added
the
enhancement
|
@J-N-K seems that the credits in the log message were removed. |
|
I guess that is a wrong edit during merging. |
I changed nothing when merging, I just take and keep unchanged what GitHub proposed. As there was at least one "Signed-off-by", I did not ask myself more questions. |
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
miloit
pushed a commit
to miloit/openhab-addons
that referenced
this pull request
Mar 10, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: miloit <MichaelLoercher@web.de>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed in Calimero 2.4.
Carryover from smarthomej/addons#104.
Also-by: Jan N. Klug github@klug.nrw