Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evcc] Fixes & Adjust to more breaking changes from evcc 0.111.x #14381

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

florian-h05
Copy link
Contributor

Fixes #14293.

Description

  • Fixes wrong DTO for the activePhases channel
  • Fixes wrong units for vehicle and battery capacity channels
  • Fixes wrong getter used for batteryPrioritySoC channel

All these fixes are for evcc 0.111.1, this PR is a follow-up for #14245 to fix the leftovers.

Testing

The user who reported the linked issue verified that the fix is working for the intended evcc version.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added the bug An unexpected problem or unintended behavior of an add-on label Feb 10, 2023
@florian-h05 florian-h05 requested a review from jlaur February 10, 2023 22:31
@florian-h05 florian-h05 changed the title [evcc] Fixes & Adjust to breaking changes from evcc 0.111.1 [evcc] Fixes & Adjust to more breaking changes from evcc 0.111.1 Feb 10, 2023
@florian-h05 florian-h05 changed the title [evcc] Fixes & Adjust to more breaking changes from evcc 0.111.1 [evcc] Fixes & Adjust to more breaking changes from evcc 0.111.x Feb 10, 2023
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 988fde1 into openhab:main Feb 10, 2023
@jlaur jlaur added this to the 4.0 milestone Feb 10, 2023
@florian-h05 florian-h05 deleted the evcc-fixes branch February 10, 2023 22:58
kaikreuzer pushed a commit that referenced this pull request Feb 11, 2023
)

* [evcc] Adjust DTO for renamed activePhases
* [evcc] Correct wrong units for capacities
* [evcc] Fix wrong getter & Reformat

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@kaikreuzer kaikreuzer added the patch A PR that has been cherry-picked to a patch release branch label Feb 13, 2023
SMHRambo pushed a commit to SMHRambo/openhab-addons that referenced this pull request Feb 14, 2023
…nhab#14381)

* [evcc] Adjust DTO for renamed activePhases
* [evcc] Correct wrong units for capacities
* [evcc] Fix wrong getter & Reformat

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
…nhab#14381)

* [evcc] Adjust DTO for renamed activePhases
* [evcc] Correct wrong units for capacities
* [evcc] Fix wrong getter & Reformat

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
…nhab#14381)

* [evcc] Adjust DTO for renamed activePhases
* [evcc] Correct wrong units for capacities
* [evcc] Fix wrong getter & Reformat

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
…nhab#14381)

* [evcc] Adjust DTO for renamed activePhases
* [evcc] Correct wrong units for capacities
* [evcc] Fix wrong getter & Reformat

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[evcc] 0.111.x: some values not recognized / incorrectly interpretet
3 participants