Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.homeassistant] support command_template for fan components #14233

Merged

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jan 16, 2023

No description provided.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

@lolodomo
Copy link
Contributor

@antroids : your review is welcome.

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Jan 21, 2023
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit f3ca325 into openhab:main Jan 27, 2023
@lolodomo lolodomo added this to the 4.0 milestone Jan 27, 2023
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
…nhab#14233)

* [mqtt.homeassistant] support command_template for fan components
* [mqtt.homeassistant] fix field declaration for consistency

Signed-off-by: Cody Cutrer <cody@cutrer.us>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
…nhab#14233)

* [mqtt.homeassistant] support command_template for fan components
* [mqtt.homeassistant] fix field declaration for consistency

Signed-off-by: Cody Cutrer <cody@cutrer.us>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
…nhab#14233)

* [mqtt.homeassistant] support command_template for fan components
* [mqtt.homeassistant] fix field declaration for consistency

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer deleted the mqtt-homeassistant-fan-command_template branch November 29, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants