[gree] Allow wider temperature range #14217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
|
@lsiepel - does it work correctly when having this definition where minimum is still 16? |
|
I probably merged too fast, sorry ! |
|
The user that tested was able to send a 7 celsius command, guess he used textual config as the quoted code would only affect Graphic config right? I'll make a PR fast :-) |
Sorry, i also missed it. |
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* Fix checkstyle * Allow wider temp range * Remaining checkstyle Signed-off-by: lsiepel <leosiepel@gmail.com>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* Fix checkstyle * Allow wider temp range * Remaining checkstyle Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the binding limits the setpoint temperature from 16-30. As devices have different operating range, it would be better to have a wider allowed range and adjust it with sitemap minValue/ maxValue according to your specific device.
Tested and confirmed. Devices gracefully ignore temperatures outside of the operating range. So regressions or device mallfunction is not to be expected.
Fixes: #14207