[modbus] Support for after connection delays #12642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalonen
requested changes
Apr 22, 2022
bundles/org.openhab.binding.modbus/src/main/resources/OH-INF/thing/bridge-serial.xml
Outdated
Show resolved
Hide resolved
ssalonen
added
the
enhancement
|
CI build fails as expected since |
|
I addressed review comments on docs and configuration, also removed unrelated formatting changes put by editor. Lets wait for build server to see. |
lolodomo
added
rebuild
wborn
requested changes
Apr 24, 2022
@wborn I don't see any of options in binding translated, so it is consistent with current way how binding works. |
|
My bad, I supposed there would be a |
wborn
changed the title
ssalonen
requested changes
Apr 30, 2022
lolodomo
requested changes
May 4, 2022
bundles/org.openhab.binding.modbus/src/main/resources/OH-INF/thing/bridge-tcp.xml
Show resolved
Hide resolved
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
…ices. Fixes openhab#12641. Signed-off-by: Łukasz Dywicki <luke@code-house.org>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…ices. (openhab#12642) Fixes openhab#12641. Signed-off-by: Łukasz Dywicki <luke@code-house.org>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…ices. (openhab#12642) Fixes openhab#12641. Signed-off-by: Łukasz Dywicki <luke@code-house.org> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…ices. (openhab#12642) Fixes openhab#12641. Signed-off-by: Łukasz Dywicki <luke@code-house.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description in #12641 - allow to make an arbitrary delay after connection is made so device connected by rtu/tcp (both connection kinds are patched) can prepare their side for further communication.