Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nuvo] Fix Nuvo Grand Concerto Detection #12613

Merged
merged 1 commit into from
Apr 24, 2022
Merged

[nuvo] Fix Nuvo Grand Concerto Detection #12613

merged 1 commit into from
Apr 24, 2022

Conversation

boc-tothefuture
Copy link
Contributor

The binding has a typo in detecting grand concerto systems - I noticed this because my clock was not being set correctly. This PR fixes the typo and also adds debug logging to determine if a GC is detected or not.

@boc-tothefuture boc-tothefuture force-pushed the nuvo_fix_gc_detection branch 2 times, most recently from 9c8a778 to 48ee3dc Compare April 16, 2022 16:12
@broconne
Fix Nuvo Grand Concerto Detection
19eca56 
Signed-off-by: Brian OConnell <broconne@gmail.com>
@boc-tothefuture
Copy link
Contributor Author

FYI - I attempted to fix the DCO - but not sure why it is still unhappy with my signoff.

@jlaur
Copy link
Contributor

jlaur commented Apr 16, 2022

FYI - I attempted to fix the DCO - but not sure why it is still unhappy with my signoff.

There seems to be some inconsistency:

Commit sha: 19eca56, Author: Brian OConnell, Committer: Brian OConnell; boc-tothefuture broconne+github@gmail.com is not a valid email address.
(linking to GitHub user broconne)

and:
Signed-off-by: Brian OConnell <broconne@gmail.com>

mlobstein
mlobstein approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@mlobstein mlobstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boc-tothefuture
Copy link
Contributor Author

FYI - I attempted to fix the DCO - but not sure why it is still unhappy with my signoff.

There seems to be some inconsistency:

Commit sha: 19eca56, Author: Brian OConnell, Committer: Brian OConnell; boc-tothefuture broconne+github@gmail.com is not a valid email address.
(linking to GitHub user broconne)

and:
Signed-off-by: Brian OConnell <broconne@gmail.com>

The first dco issue was that it doesn't like my email address, so I changed it. At this point not sure how to resolve it.

lolodomo
lolodomo approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Apr 22, 2022
@lolodomo
Copy link
Contributor

@jlaur: do you have an idea?
Or do we make an exception as it is only 4 lines changed?

@jlaur
Copy link
Contributor

jlaur commented Apr 23, 2022

@jlaur: do you have an idea? Or do we make an exception as it is only 4 lines changed?

@lolodomo - we can fix sign-off when squash-merging. @boc-tothefuture, which e-mail address is the correct one?

@wborn
Copy link
Member

wborn commented Apr 23, 2022

When contributors agree to the DCO and provide a valid email, you can also click the "Set DCO to pass" button to fix it. You get there by clicking on "Details" besides the DCO check.

Screenshot from 2022-04-23 13-39-02

@lolodomo lolodomo merged commit 433ab4d into openhab:main Apr 24, 2022
@lolodomo
Copy link
Contributor

Done. I considered broconne@gmail.com is valid.

@lolodomo lolodomo added this to the 3.3 milestone Apr 24, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@boc-tothefuture @NickWaterton
Fix Nuvo Grand Concerto Detection (openhab#12613)
92bb753 
Signed-off-by: Brian OConnell <broconne@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@boc-tothefuture @andan67
Fix Nuvo Grand Concerto Detection (openhab#12613)
31129f6 
Signed-off-by: Brian OConnell <broconne@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@boc-tothefuture @andrasU
Fix Nuvo Grand Concerto Detection (openhab#12613)
54d989a 
Signed-off-by: Brian OConnell <broconne@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@boc-tothefuture @psmedley
Fix Nuvo Grand Concerto Detection (openhab#12613)
8e7d142 
Signed-off-by: Brian OConnell <broconne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlobstein mlobstein mlobstein approved these changes

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@boc-tothefuture @jlaur @lolodomo @wborn @mlobstein