[pulseaudio] Allow flexible parameters to find a given pulseaudio device #12598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To identify the device on the pulseaudio server, you can now use the description instead of the technical id (a.k.a. "name"). To filter furthermore, you can also use the parameter additionalFilters (optional regular expressions that need to match a property value of a device on the pulseaudio server) Closes openhab#12555 Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
dalgwen
added
the
enhancement
lolodomo
requested changes
Apr 25, 2022
...lseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/handler/DeviceIdentifier.java
Outdated
Show resolved
Hide resolved
...nding.pulseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/PulseaudioClient.java
Outdated
Show resolved
Hide resolved
Apply suggestions from code review Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
|
Thank you again @lolodomo |
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…ice (openhab#12598) * [pulseaudio] Allow flexible parameters to find a given pulseaudio device To identify the device on the pulseaudio server, you can now use the description instead of the technical id (a.k.a. "name"). To filter furthermore, you can also use the parameter additionalFilters (optional regular expressions that need to match a property value of a device on the pulseaudio server) Closes openhab#12555 Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…ice (openhab#12598) * [pulseaudio] Allow flexible parameters to find a given pulseaudio device To identify the device on the pulseaudio server, you can now use the description instead of the technical id (a.k.a. "name"). To filter furthermore, you can also use the parameter additionalFilters (optional regular expressions that need to match a property value of a device on the pulseaudio server) Closes openhab#12555 Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
dalgwen
deleted the
12555_pulseaudio_also_use_description_as_identifier
branch
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…ice (openhab#12598) * [pulseaudio] Allow flexible parameters to find a given pulseaudio device To identify the device on the pulseaudio server, you can now use the description instead of the technical id (a.k.a. "name"). To filter furthermore, you can also use the parameter additionalFilters (optional regular expressions that need to match a property value of a device on the pulseaudio server) Closes openhab#12555 Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the request of a user, who had difficulties with its pulseaudio devices and the random naming occuring (#12555) , I would like to add some (non breaking) possibilities in the way to choose a pulseaudio device corresponding to a thing description.
To identify the device on the pulseaudio server, with this PR, you can now use the description instead of the technical id (a.k.a. "name").
To filter furthermore, you can also use the parameter additionalFilters (optional regular expressions that need to match a property value of a device on the pulseaudio server).
As you can see in the related discussion, these two modifications were necessary to match an interesting use case (playing sound to airplay device with the help of the RAOP pulseaudio module as an intermediary)
Closes #12555
A snapshot is here
Signed-off-by: Gwendal Roulleau gwendal.roulleau@gmail.com