Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugwiseha] Add and enhance channels #12349

Merged
merged 9 commits into from
Feb 23, 2022
Merged

[plugwiseha] Add and enhance channels #12349

merged 9 commits into from
Feb 23, 2022

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 22, 2022

  1. Add Zone => cooling_allowed channel (r/w)
  2. Add Zone => regulation_control channel (r/w)
  3. Fix documentation mistake=> preheating_allowed channel is r/w
  4. Changed Zone => scene channel from read-only to r/w.
  5. Minor codestyle improvements

No configuration or other changes needed for the end-user.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/plugwise-home-automation-binding-for-openhab/81299/136

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Feb 22, 2022
@lolodomo
Copy link
Contributor

Default translations properties must be updated.

@lsiepel
Fix review comments
9e78966 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Add additional state option translations
42af1df 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Copy link
Contributor Author

lsiepel commented Feb 23, 2022

Default translations properties must be updated.

I think i fixed them. Could you check? I'm new to these translations.

@lolodomo
Copy link
Contributor

I think i fixed them. Could you check? I'm new to these translations.

Just run : mvn org.openhab.core.tools:i18n-maven-plugin:3.2.0:generate-default-translations

@lsiepel
Fix default translation
de047e1 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Copy link
Contributor Author

lsiepel commented Feb 23, 2022

I think i fixed them. Could you check? I'm new to these translations.

Just run : mvn org.openhab.core.tools:i18n-maven-plugin:3.2.0:generate-default-translations

Thanks! Got it sorted. I think all is good now.

@lsiepel lsiepel closed this Feb 23, 2022
@lsiepel lsiepel reopened this Feb 23, 2022
lolodomo
lolodomo approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit ea9d77f into openhab:main Feb 23, 2022
@lolodomo lolodomo added this to the 3.3 milestone Feb 23, 2022
@lsiepel lsiepel deleted the plugwiseha-morechannels branch February 24, 2022 08:07
lsiepel added a commit to lsiepel/openhab-addons that referenced this pull request Feb 24, 2022
@lsiepel
Fix bug introduced with openhab#12349
fa1ea31 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lolodomo pushed a commit that referenced this pull request Feb 25, 2022
@lsiepel
[plugwiseha] Fix bug introduced with #12349 (#12366)
da0234f 
* Fix bug introduced with #12349

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@lsiepel @NickWaterton
[plugwiseha] Add and enhance channels (openhab#12349)
4bb5cb8 
* Add two-channels, fix scene and docs

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@lsiepel @NickWaterton
[plugwiseha] Fix bug introduced with openhab#12349 (openhab#12366)
fea3147 
* Fix bug introduced with openhab#12349

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jun 29, 2022
@lsiepel @nemerdaud
[plugwiseha] Add and enhance channels (openhab#12349)
9d6d4ec 
* Add two-channels, fix scene and docs

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jun 29, 2022
@lsiepel @nemerdaud
[plugwiseha] Fix bug introduced with openhab#12349 (openhab#12366)
a51a2c5 
* Fix bug introduced with openhab#12349

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@lsiepel @andan67
[plugwiseha] Add and enhance channels (openhab#12349)
ca38099 
* Add two-channels, fix scene and docs

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@lsiepel @andan67
[plugwiseha] Fix bug introduced with openhab#12349 (openhab#12366)
97a65a7 
* Fix bug introduced with openhab#12349

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@lsiepel @andrasU
[plugwiseha] Add and enhance channels (openhab#12349)
756a885 
* Add two-channels, fix scene and docs

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@lsiepel @andrasU
[plugwiseha] Fix bug introduced with openhab#12349 (openhab#12366)
b9147ec 
* Fix bug introduced with openhab#12349

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@lsiepel @psmedley
[plugwiseha] Add and enhance channels (openhab#12349)
1ce1eff 
* Add two-channels, fix scene and docs

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@lsiepel @psmedley
[plugwiseha] Fix bug introduced with openhab#12349 (openhab#12366)
9f206ba 
* Fix bug introduced with openhab#12349

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lsiepel @openhab-bot @lolodomo