[mqtt.homie] handle exceptions parsing attributes #12254

ccutrer · 2022-02-09T21:43:04Z

technically this code is in mqtt.generic, but it's only used by Homie.

in particular, if an incoming string doesn't match an enum, this will now
just ignore the value instead of raising an exception to be caught somewhere inside
of Hive MQTT, and eventually timing out and logging that mandatory topics weren't
received, instead of logging a pointer to the actual problem. this makes it so that
if there's a homie $datatype openhab doesn't understand (like duration), it will be
able to get to the point of just choosing a string channel

also did some minor debug logging cleanup for mqtt:

fixed a typo
when logging homie device name from the thing handler, use the config deviceid,
since we likely don't have the attributes from MQTT yet

fixes openhab#10711 technically this code is in mqtt.generic, but it's only used by Homie. in particular, if an incoming string doesn't match an enum, this will now just ignore the value instead of raising an exception to be caught somewhere inside of Hive MQTT, and eventually timing out and logging that mandatory topics weren't received, instead of logging a pointer to the actual problem. this makes it so that if there's a homie $datatype openhab doesn't understand (like duration), it will be able to get to the point of just choosing a string channel also did some minor debug logging cleanup for mqtt: * fixed a typo * when logging homie device name from the thing handler, use the config deviceid, since we likely don't have the attributes from MQTT yet Signed-off-by: Cody Cutrer <cody@cutrer.us>

lolodomo

LGTM

fixes openhab#10711 technically this code is in mqtt.generic, but it's only used by Homie. in particular, if an incoming string doesn't match an enum, this will now just ignore the value instead of raising an exception to be caught somewhere inside of Hive MQTT, and eventually timing out and logging that mandatory topics weren't received, instead of logging a pointer to the actual problem. this makes it so that if there's a homie $datatype openhab doesn't understand (like duration), it will be able to get to the point of just choosing a string channel also did some minor debug logging cleanup for mqtt: * fixed a typo * when logging homie device name from the thing handler, use the config deviceid, since we likely don't have the attributes from MQTT yet Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Nick Waterton <n.waterton@outlook.com>

fixes openhab#10711 technically this code is in mqtt.generic, but it's only used by Homie. in particular, if an incoming string doesn't match an enum, this will now just ignore the value instead of raising an exception to be caught somewhere inside of Hive MQTT, and eventually timing out and logging that mandatory topics weren't received, instead of logging a pointer to the actual problem. this makes it so that if there's a homie $datatype openhab doesn't understand (like duration), it will be able to get to the point of just choosing a string channel also did some minor debug logging cleanup for mqtt: * fixed a typo * when logging homie device name from the thing handler, use the config deviceid, since we likely don't have the attributes from MQTT yet Signed-off-by: Cody Cutrer <cody@cutrer.us>

fixes openhab#10711 technically this code is in mqtt.generic, but it's only used by Homie. in particular, if an incoming string doesn't match an enum, this will now just ignore the value instead of raising an exception to be caught somewhere inside of Hive MQTT, and eventually timing out and logging that mandatory topics weren't received, instead of logging a pointer to the actual problem. this makes it so that if there's a homie $datatype openhab doesn't understand (like duration), it will be able to get to the point of just choosing a string channel also did some minor debug logging cleanup for mqtt: * fixed a typo * when logging homie device name from the thing handler, use the config deviceid, since we likely don't have the attributes from MQTT yet Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

fixes openhab#10711 technically this code is in mqtt.generic, but it's only used by Homie. in particular, if an incoming string doesn't match an enum, this will now just ignore the value instead of raising an exception to be caught somewhere inside of Hive MQTT, and eventually timing out and logging that mandatory topics weren't received, instead of logging a pointer to the actual problem. this makes it so that if there's a homie $datatype openhab doesn't understand (like duration), it will be able to get to the point of just choosing a string channel also did some minor debug logging cleanup for mqtt: * fixed a typo * when logging homie device name from the thing handler, use the config deviceid, since we likely don't have the attributes from MQTT yet Signed-off-by: Cody Cutrer <cody@cutrer.us>

ccutrer requested a review from davidgraeff as a code owner February 9, 2022 21:43

lolodomo added the enhancement An enhancement or new feature for an existing add-on label Feb 12, 2022

lolodomo approved these changes Feb 23, 2022

View reviewed changes

lolodomo merged commit 923fb12 into openhab:main Feb 23, 2022

lolodomo added this to the 3.3 milestone Feb 23, 2022

ccutrer deleted the home_handle_invalid_attributes branch September 26, 2022 20:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mqtt.homie] handle exceptions parsing attributes #12254

[mqtt.homie] handle exceptions parsing attributes #12254

ccutrer commented Feb 9, 2022

lolodomo left a comment

[mqtt.homie] handle exceptions parsing attributes #12254

[mqtt.homie] handle exceptions parsing attributes #12254

Conversation

ccutrer commented Feb 9, 2022

lolodomo left a comment

Choose a reason for hiding this comment