[teleinfo] Refactor channel config files for Linky standard mode #12204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
|
Did you run the i18n tool? Normally it should generate no changes in the properties file. |
lolodomo
added
the
enhancement
It still generates one duplicate but this one comes from an old part of the binding on which I'm less familiar. [edit] I think I've got it, i will push an update on this PR if it's not to late. |
|
Last question: don't you prefer to remove the file common-cbemm-evo-icc-channel-types.xml which contains only this channel? |
Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
olivierkeke
force-pushed
the
xml-configuration-clean-up
branch
from
a83696a to
1b99527
Compare
You're right, I've amended the last commit. |
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
…nhab#12204) * Refactor channel config files * Remove duplicate PAPP channel type Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
…nhab#12204) * Refactor channel config files * Remove duplicate PAPP channel type Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…nhab#12204) * Refactor channel config files * Remove duplicate PAPP channel type Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…nhab#12204) * Refactor channel config files * Remove duplicate PAPP channel type Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…nhab#12204) * Refactor channel config files * Remove duplicate PAPP channel type Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Marceau hollysaiqs@marceau.ovh
This PR removes some channel-type xml definitions duplicated in several config files.