[enocean] enable usage of Nodon roller-shutter repeater mode #12133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Eckert <mrcleckert@aol.com>
Signed-off-by: Marcel Eckert <mrcleckert@aol.com>
SoCsOnFPGAsGuy
changed the title
lolodomo
added
the
enhancement
lolodomo
requested changes
Jan 27, 2022
...ing.enocean/src/main/java/org/openhab/binding/enocean/internal/eep/D2_05/D2_05_00_NodON.java
Outdated
Show resolved
Hide resolved
...ing.enocean/src/main/java/org/openhab/binding/enocean/internal/eep/D2_05/D2_05_00_NodON.java
Outdated
Show resolved
Hide resolved
…ments Signed-off-by: Marcel Eckert <mrcleckert@aol.com>
|
@fruggy83 ; is it ok for you? |
lolodomo
added
rebuild
fruggy83
reviewed
Jan 30, 2022
There was a problem hiding this comment.
@SoCsOnFPGAsGuy thanks a lot for your work and sorry for my late review. Maybe my comments are helpful for another PR in the future :)
@lolodomo Thanks a lot for your review and pushing this PR. Sorry, I just came back from a short trip today.
| | | broadcastMessages | | true, false | | ||
| | | receivingEEPId¹ | | A5_3F_7F_EltakoFSB, A5_3F_7F_EltakoFRM, A5_11_03, D2_05_00 | | ||
| | | receivingEEPId¹ | | A5_3F_7F_EltakoFSB, A5_3F_7F_EltakoFRM, A5_11_03, D2_05_00_NODON | |
There was a problem hiding this comment.
According to the rollershutter.xml the D2_05_00 EEP is still valid.
| @Override | ||
| protected void convertFromCommandImpl(String channelId, String channelTypeId, Command command, | ||
| Function<String, State> getCurrentStateFunc, Configuration config) { | ||
| if (channelId.equals(CHANNEL_REPEATERMODE)) { |
There was a problem hiding this comment.
I know that channelId should currently never be NULL, however I would just switch the comparision.
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
…#12133) * [enocean] enable repeater mode selection for NODON rollershutter * [enocean] adds new EEP definition for NODON rollershutter to README.md Signed-off-by: Marcel Eckert <mrcleckert@aol.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
…#12133) * [enocean] enable repeater mode selection for NODON rollershutter * [enocean] adds new EEP definition for NODON rollershutter to README.md Signed-off-by: Marcel Eckert <mrcleckert@aol.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…#12133) * [enocean] enable repeater mode selection for NODON rollershutter * [enocean] adds new EEP definition for NODON rollershutter to README.md Signed-off-by: Marcel Eckert <mrcleckert@aol.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…#12133) * [enocean] enable repeater mode selection for NODON rollershutter * [enocean] adds new EEP definition for NODON rollershutter to README.md Signed-off-by: Marcel Eckert <mrcleckert@aol.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…#12133) * [enocean] enable repeater mode selection for NODON rollershutter * [enocean] adds new EEP definition for NODON rollershutter to README.md Signed-off-by: Marcel Eckert <mrcleckert@aol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NODONs in Wall Modules SIN-2-2-00 and SIN-2-1-0x it is already possible to adjust the repeater mode. For NODONs roller-shutter (SIN-2-RS-01) this wasn't possibly with openhab so far - this series of commits enables the repeater mode setting in openhab also for NODONs roller-shutter modules, the same way it is done for the other two in Wall Modules.
Correctness also tested physically with some of the roller-shutter modules in my own house.