[hdpowerview] Added shade type 65 to database #12081
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
the
enhancement
|
@andrewfg - consider if PR title should be changed to "[hdpowerview] Add full support for Vignette Duolite" or something more specific for the release notes? As I understand it, adding correct capabilities to the database will ensure that position calculations are correct, so without it defaults are used, which can lead to some undesired behavior? |
|
@jlaur I chose the title 'Update Shade Database' because there will be several such generic updates, and this is just one of many. The PR description (will) say(s) what was actually updated in each PR. Note: this new shade type has an existing 'capabilities' value, so its functionality has already been coded, and therefore no functional changes are required now.. |
|
I agree that a more precise title would be better. |
andrewfg
changed the title
* [hdpowerview] update shade database * [hdpowerview] add type 65 shade capabilities 8 Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [hdpowerview] update shade database * [hdpowerview] add type 65 shade capabilities 8 Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
* [hdpowerview] update shade database * [hdpowerview] add type 65 shade capabilities 8 Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [hdpowerview] update shade database * [hdpowerview] add type 65 shade capabilities 8 Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Add Shade type 65 to database.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch