[oppo] Fix Play Mode and Disc Type updates #12066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
lolodomo
requested changes
Jan 17, 2022
...penhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/handler/OppoHandler.java
Outdated
Show resolved
Hide resolved
...ding.oppo/src/main/java/org/openhab/binding/oppo/internal/communication/OppoStatusCodes.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
moesterheld
pushed a commit
to moesterheld/openhab-addons
that referenced
this pull request
Jan 18, 2022
* Fix Play Mode and Disc Type updates Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* Fix Play Mode and Disc Type updates Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
* Fix Play Mode and Disc Type updates Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Fix Play Mode and Disc Type updates Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Fix Play Mode and Disc Type updates Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #12064
In some configurations, the player sends unsolicited updates but the update message is an abbreviated code when compared to the longer response provided by the query command that must used in other configurations. The previous strategy to immediately call the query command upon receiving an unsolicited update was flawed in that the query command sometimes provided an outdated value. This PR fixes the issue for Play Mode and Disc Type by mapping the abbreviated unsolicited update code to the values provided by the query command. For Audio Type and Subtitle Type, a slight delay was added before calling the query command.