[rfxcom] Support for Lucciair DC Speed #12038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/rfxcom-add-on-support-for-lucciair-dc-speed-1-to-6/131625/2 |
lolodomo
changed the title
lolodomo
added
the
enhancement
|
Looks like this PR contains changes from another PR I just merged. |
martinvw
force-pushed
the
feature/lucca-fan-speed
branch
from
c5eb681 to
659988e
Compare
@lolodomo I rebased, it should be fine now, thanks for the quick review of my PR |
|
@martinvw : what do you want to do with this PR ? It is still marked as draft/WIP. |
|
Fair point I still need to come up with a good solution for the the backwards compatibility any suggestions? Thanks! |
I see no good solution. But a solution is to inform users through the release notes. |
Signed-off-by: Martin van Wingerden <martin@martinvw.nl>
Signed-off-by: Martin van Wingerden <martin@martinvw.nl>
martinvw
force-pushed
the
feature/lucca-fan-speed
branch
from
5c8b347 to
a1771cb
Compare
Signed-off-by: Martin van Wingerden <martin@martinvw.nl>
martinvw
changed the title
|
@lolodomo ready! |
kaikreuzer
pushed a commit
to openhab/openhab-distro
that referenced
this pull request
Mar 3, 2022
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
* [rfxcom] Support speed for luca DC version * [rfxcom] Handle null value for speed * [rfxcom] Update readme and add migration channel Signed-off-by: Martin van Wingerden <martin@martinvw.nl> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [rfxcom] Support speed for luca DC version * [rfxcom] Handle null value for speed * [rfxcom] Update readme and add migration channel Signed-off-by: Martin van Wingerden <martin@martinvw.nl>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* [rfxcom] Support speed for luca DC version * [rfxcom] Handle null value for speed * [rfxcom] Update readme and add migration channel Signed-off-by: Martin van Wingerden <martin@martinvw.nl> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* [rfxcom] Support speed for luca DC version * [rfxcom] Handle null value for speed * [rfxcom] Update readme and add migration channel Signed-off-by: Martin van Wingerden <martin@martinvw.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for speed for the regular Lucciair DC Fan
See also: https://community.openhab.org/t/rfxcom-add-on-support-for-lucciair-dc-speed-1-to-6/131625