[guntamatic] Initial contribution: Binding for Guntamatic Heating Systems #12011

MikeTheTux · 2022-01-09T18:25:45Z

Initial contribution: Binding for Guntamatic Heating Systems (Biostar, Powerchip, Powercorn, Biocom, Pro, Therm)

I have implemented a Binding that can be used to monitor and control Guntamatic Heating Systems (https://www.guntamatic.com/en/).

The Guntamatic Binding was developed and tested using Guntamatic Biostar 15kW Pellets Heating System running Firmware 3.2d.
It should work for all other Guntamatic Heating Systems as well, that support the same web interface:

Biostar (tested via 15kW, firmware 3.2d)
Powerchip (untested)
Powercorn (untested)
Biocom (untested)
Pro (untested)
Therm (untested)

Forum topic:

#128451

Test Build:

org.openhab.binding.guntamatic-3.2.0-SNAPSHOT_v2.2.1.zip

Final Build:

org.openhab.binding.guntamatic-3.3.0-SNAPSHOT_v2.3.0.zip

update

Signed-off-by: Michael Weger <weger.michael@gmx.net>

MikeTheTux · 2022-01-09T18:27:14Z

@lolodomo please find here the new PR, started from current OH3.3.0 SNAPSHOT HEAD.
Previous PR: #11598

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

lolodomo · 2022-01-09T18:40:27Z

I submitted a PR to your repo including the default translation properties.

Default translation properties

MikeTheTux · 2022-01-09T19:29:06Z

Bad news: i18n still fails

D:\openhab-addons-guntamatic\bundles\org.openhab.binding.guntamatic>mvn i18n:generate-default-translations
[INFO] Scanning for projects...
[WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available
[WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failure to find org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 in https://repo1.maven.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced
[WARNING] The POM for org.openhab.core.tools:i18n-maven-plugin:jar:3.3.0-SNAPSHOT is missing, no dependency information available
[WARNING] Failed to retrieve plugin descriptor for org.openhab.core.tools:i18n-maven-plugin:3.3.0-SNAPSHOT: Plugin org.openhab.core.tools:i18n-maven-plugin:3.3.0-SNAPSHOT or one of its dependencies could not be resolved: Failure to find org.openhab.core.tools:i18n-maven-plugin:jar:3.3.0-SNAPSHOT in https://repo1.maven.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced
Downloading from central: https://repo1.maven.org/maven2/org/codehaus/mojo/maven-metadata.xml
Downloading from central: https://repo1.maven.org/maven2/org/apache/maven/plugins/maven-metadata.xml
Downloading from openhab-release: https://openhab.jfrog.io/openhab/libs-release/org/codehaus/mojo/maven-metadata.xml
Downloading from openhab-release: https://openhab.jfrog.io/openhab/libs-release/org/apache/maven/plugins/maven-metadata.xml
Downloaded from central: https://repo1.maven.org/maven2/org/codehaus/mojo/maven-metadata.xml (20 kB at 41 kB/s)
Downloaded from central: https://repo1.maven.org/maven2/org/apache/maven/plugins/maven-metadata.xml (14 kB at 28 kB/s)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.152 s
[INFO] Finished at: 2022-01-09T19:29:34+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] No plugin found for prefix 'i18n' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (C:\Users\mike\.m2\repository), central (https://repo1.maven.org/maven2), openhab-release (https://openhab.jfrog.io/openhab/libs-release)] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/NoPluginFoundForPrefixException

MikeTheTux · 2022-01-09T19:29:47Z

I submitted a PR to your repo including the default translation properties.

reviewed and merged ...

lolodomo · 2022-01-09T22:10:19Z

@MikeTheTux : I submitted a very last PR to your repo with improvements for your thing handler.
What is required is the additional exception catching in parseAndJsonInit.
Using constants from CoreItemFactory is better.
All the other changes are more suggestions to you.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

Improvements in the thing handler

Signed-off-by: Michael Weger <weger.michael@gmx.net>

MikeTheTux · 2022-01-10T19:03:42Z

@MikeTheTux : I submitted a very last PR to your repo with improvements for your thing handler. What is required is the additional exception catching in parseAndJsonInit. Using constants from CoreItemFactory is better. All the other changes are more suggestions to you.

reviewed, merged and updated

lolodomo

Code LGTM

lolodomo · 2022-01-10T21:35:31Z

@MikeTheTux : do you want time for retesting or do you give me the go for merging?

MikeTheTux · 2022-01-11T08:08:08Z

@MikeTheTux : do you want time for retesting or do you give me the go for merging?

Please let me do some final testing before the merge.

MikeTheTux · 2022-01-11T20:51:11Z

Code LGTM

go for it 🚀

thanks for all your effors. I owe you one 🍺

lolodomo · 2022-01-11T21:37:18Z

@MikeTheTux : thank your for contributing this new binding.

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

MikeTheTux · 2022-01-12T18:26:56Z

@MikeTheTux : thank your for contributing this new binding.

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

openhab/openhab-docs#1733

…tems (openhab#12011) Signed-off-by: Michael Weger <weger.michael@gmx.net>

…tems (openhab#12011) Signed-off-by: Michael Weger <weger.michael@gmx.net> Signed-off-by: Nick Waterton <n.waterton@outlook.com>

…tems (openhab#12011) Signed-off-by: Michael Weger <weger.michael@gmx.net>

…tems (openhab#12011) Signed-off-by: Michael Weger <weger.michael@gmx.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

MikeTheTux and others added 7 commits March 27, 2021 19:53

Merge pull request #1 from openhab/main

70da552

update

Merge branch 'openhab:main' into main

9fdfd26

Merge branch 'openhab:main' into main

8fdf5b9

Merge branch 'openhab:main' into main

218bdbd

Merge branch 'openhab:main' into main

5d9bd1b

Merge branch 'openhab:main' into main

e9887c3

[guntamatic] Initial contribution

1d01254

Signed-off-by: Michael Weger <weger.michael@gmx.net>

MikeTheTux requested a review from a team as a code owner January 9, 2022 18:25

Default translation properties

915ab8b

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Jan 9, 2022

Merge pull request #2 from lolodomo/guntamatic_i18n

28e15c9

Default translation properties

lolodomo and others added 3 commits January 9, 2022 23:50

Improvements in the thing handler

7c59540

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

Merge pull request #3 from lolodomo/guntamatic_handler

efa0d89

Improvements in the thing handler

removed warning during init

313ae81

Signed-off-by: Michael Weger <weger.michael@gmx.net>

lolodomo approved these changes Jan 10, 2022

View reviewed changes

lolodomo merged commit 7b0ba30 into openhab:main Jan 11, 2022

lolodomo added this to the 3.3 milestone Jan 11, 2022

MikeTheTux mentioned this pull request Jan 12, 2022

[guntamatic] logo openhab/openhab-docs#1733

Merged

moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022

[guntamatic] Initial contribution: Binding for Guntamatic Heating Sys…

a750f65

…tems (openhab#12011) Signed-off-by: Michael Weger <weger.michael@gmx.net>

nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022

[guntamatic] Initial contribution: Binding for Guntamatic Heating Sys…

4de22bd

…tems (openhab#12011) Signed-off-by: Michael Weger <weger.michael@gmx.net>

MikeTheTux mentioned this pull request Jan 28, 2022

[guntamatic] Added 'biosmart' and 'generic' thingtype, robustness improvements on control interface #12146

Merged

andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022

[guntamatic] Initial contribution: Binding for Guntamatic Heating Sys…

98da176

…tems (openhab#12011) Signed-off-by: Michael Weger <weger.michael@gmx.net>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[guntamatic] Initial contribution: Binding for Guntamatic Heating Systems #12011

[guntamatic] Initial contribution: Binding for Guntamatic Heating Systems #12011

MikeTheTux commented Jan 9, 2022 •

edited

Loading

MikeTheTux commented Jan 9, 2022 •

edited

Loading

lolodomo commented Jan 9, 2022

MikeTheTux commented Jan 9, 2022 •

edited

Loading

MikeTheTux commented Jan 9, 2022

lolodomo commented Jan 9, 2022

MikeTheTux commented Jan 10, 2022

lolodomo left a comment

lolodomo commented Jan 10, 2022

MikeTheTux commented Jan 11, 2022

MikeTheTux commented Jan 11, 2022

lolodomo commented Jan 11, 2022

MikeTheTux commented Jan 12, 2022

[guntamatic] Initial contribution: Binding for Guntamatic Heating Systems #12011

[guntamatic] Initial contribution: Binding for Guntamatic Heating Systems #12011

Conversation

MikeTheTux commented Jan 9, 2022 • edited Loading

MikeTheTux commented Jan 9, 2022 • edited Loading

lolodomo commented Jan 9, 2022

MikeTheTux commented Jan 9, 2022 • edited Loading

MikeTheTux commented Jan 9, 2022

lolodomo commented Jan 9, 2022

MikeTheTux commented Jan 10, 2022

lolodomo left a comment

Choose a reason for hiding this comment

lolodomo commented Jan 10, 2022

MikeTheTux commented Jan 11, 2022

MikeTheTux commented Jan 11, 2022

lolodomo commented Jan 11, 2022

MikeTheTux commented Jan 12, 2022

MikeTheTux commented Jan 9, 2022 •

edited

Loading

MikeTheTux commented Jan 9, 2022 •

edited

Loading

MikeTheTux commented Jan 9, 2022 •

edited

Loading