Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http] Provide meaningful error messages #11995

Merged
merged 1 commit into from
Jan 8, 2022
Merged

[http] Provide meaningful error messages #11995

merged 1 commit into from
Jan 8, 2022

Conversation

Flole998
Copy link
Member

@Flole998 Flole998 commented Jan 8, 2022 •
edited
Loading

RIght now error messages of the HTTP-Binding look like this:

Requesting 'https://api.corona-zahlen.org/districts/03251' (method='GET', content='null') failed: HttpConnectionOverHTTP@d01aa55::DecryptedEndPoint@3eee00d9{l=/XXXXXXX:XXXX,r=api.corona-zahlen.org/104.21.60.139:443,OPEN,fill=-,flush=-,to=599158/0}

with this change they look like this:

Requesting 'https://api.corona-zahlen.org/districts/03251' (method='GET', content='null') failed: java.io.EOFException: HttpConnectionOverHTTP@d01aa55::DecryptedEndPoint@3eee00d9{l=/XXXXXXX:XXXX,r=api.corona-zahlen.org/104.21.60.139:443,OPEN,fill=-,flush=-,to=599158/0}

Note the added java.io.EOFException: , which explains what kind of exception actually happened.

@Flole998
[http] Provide meaningful error messages
36f698c 
Signed-off-by: Flole <flole@flole.de>
@Flole998 Flole998 requested a review from a team as a code owner January 8, 2022 00:41
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Jan 8, 2022
jlaur
jlaur approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jlaur jlaur merged commit a13ce57 into openhab:main Jan 8, 2022
@jlaur jlaur added this to the 3.3 milestone Jan 8, 2022
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
@Flole998 @mischmidt83
[http] Provide meaningful error messages (openhab#11995)
47d903d 
Signed-off-by: Flole <flole@flole.de>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
@Flole998 @moesterheld
[http] Provide meaningful error messages (openhab#11995)
b157e42 
Signed-off-by: Flole <flole@flole.de>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@Flole998
[http] Provide meaningful error messages (openhab#11995)
7d070fc 
Signed-off-by: Flole <flole@flole.de>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@Flole998 @NickWaterton
[http] Provide meaningful error messages (openhab#11995)
92692df 
Signed-off-by: Flole <flole@flole.de>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@Flole998 @andan67
[http] Provide meaningful error messages (openhab#11995)
6e59225 
Signed-off-by: Flole <flole@flole.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@Flole998 @andrasU
[http] Provide meaningful error messages (openhab#11995)
f12daa7 
Signed-off-by: Flole <flole@flole.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Flole998 @jlaur @lolodomo