[dali] Fix frame packing #11936
Merged
[dali] Fix frame packing #11936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Schmid <r.schmid@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
Signed-off-by: Robert Schmid <r.schmid@outlook.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld
pushed a commit
to moesterheld/openhab-addons
that referenced
this pull request
Jan 18, 2022
Signed-off-by: Robert Schmid <r.schmid@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
Signed-off-by: Robert Schmid <r.schmid@outlook.com>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
Signed-off-by: Robert Schmid <r.schmid@outlook.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Robert Schmid <r.schmid@outlook.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Robert Schmid <r.schmid@outlook.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert Schmid r.schmid@outlook.com
This fixes an out-of-range bug that prevented DALI frames from being created.
(The counter variable that helps in copying bytes from a list into an array in reverse order should be 1 in the first loop iteration.)
This bug was introduced when I incorporated change requests as part of my original PR for the binding, and I somehow missed to test this afterwards.
With this fix, the binding works as expected. 😅
Happy new year!