[androiddebugbridge] Added mDNS discovery for Fire TV Stick #11881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweitkamp
added
the
enhancement
cweitkamp
commented
Dec 29, 2021
| editProperties.put(Thing.PROPERTY_FIRMWARE_VERSION, adbConnection.getAndroidVersion()); | ||
| editProperties.put(Thing.PROPERTY_VENDOR, adbConnection.getBrand()); | ||
| try { | ||
| editProperties.put(Thing.PROPERTY_MAC_ADDRESS, adbConnection.getMacAddress()); |
There was a problem hiding this comment.
Unfortunately the ro.boot.wifimacaddr property is not available or accessible on all devices but currently it looks like the Mac address is the only unique identifier available in both discovery service implementations.
cweitkamp
force-pushed
the
feature-adb-mdns-discovery
branch
from
bef2a2a to
8ac75dc
Compare
jlaur
reviewed
Jan 8, 2022
...enhab/binding/androiddebugbridge/internal/discovery/FireTVStickMDNSDiscoveryParticipant.java
Show resolved
Hide resolved
cweitkamp
commented
Jan 8, 2022
...enhab/binding/androiddebugbridge/internal/discovery/FireTVStickMDNSDiscoveryParticipant.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
…rg/openhab/binding/androiddebugbridge/internal/discovery/FireTVStickMDNSDiscoveryParticipant.java Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
feature-adb-mdns-discovery
branch
from
0947682 to
314fca1
Compare
lolodomo
reviewed
Jan 12, 2022
...penhab/binding/androiddebugbridge/internal/discovery/AndroidDebugBridgeDiscoveryService.java
Outdated
Show resolved
Hide resolved
|
Is changing the representation property a breaking change? |
No, I do not think so. It is an internal property which cannot be manipulated the user and if the binding has a proper handling - like I implemented it in this PR - it will be backward compatible. |
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
lolodomo
reviewed
Jan 15, 2022
...src/main/java/org/openhab/binding/androiddebugbridge/internal/AndroidDebugBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
moesterheld
pushed a commit
to moesterheld/openhab-addons
that referenced
this pull request
Jan 18, 2022
…11881) * Added mDNS discovery for Fire TV Stick Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…11881) * Added mDNS discovery for Fire TV Stick Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
…11881) * Added mDNS discovery for Fire TV Stick Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…11881) * Added mDNS discovery for Fire TV Stick Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…11881) * Added mDNS discovery for Fire TV Stick Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de