[fronius] Added Ohmpilot thing and channel realpowersum for thing meter #11835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmet0
force-pushed
the
feature/ohmpilot
branch
2 times, most recently
from
a248e06 to
2041774
Compare
lolodomo
added
the
enhancement
|
@trokohl : can you please review? |
urmet0
force-pushed
the
feature/ohmpilot
branch
from
f20fee3 to
7b7f7ef
Compare
|
@trokohl if you have any questions, please let me know. |
lolodomo
requested changes
Feb 7, 2022
...onius/src/main/java/org/openhab/binding/fronius/internal/handler/FroniusOhmpilotHandler.java
Outdated
Show resolved
Hide resolved
...onius/src/main/java/org/openhab/binding/fronius/internal/handler/FroniusOhmpilotHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.fronius/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.fronius/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.fronius/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.fronius/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.fronius/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
...ding.fronius/src/main/java/org/openhab/binding/fronius/internal/FroniusBindingConstants.java
Outdated
Show resolved
Hide resolved
...onius/src/main/java/org/openhab/binding/fronius/internal/handler/FroniusOhmpilotHandler.java
Outdated
Show resolved
Hide resolved
...onius/src/main/java/org/openhab/binding/fronius/internal/handler/FroniusOhmpilotHandler.java
Outdated
Show resolved
Hide resolved
urmet0
force-pushed
the
feature/ohmpilot
branch
2 times, most recently
from
ee1dfb0 to
bcd5387
Compare
lolodomo
reviewed
Feb 8, 2022
bundles/org.openhab.binding.fronius/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
|
What remains to do is the update of the file fronius.properties. You can run |
|
Im sorry, but mvn i18n:generate-default-translations does not work for me. "No plugin found for prefix 'i18n' in the current project." |
|
Please try : |
|
Thank you, this worked. |
|
There is a conflict now. The properties file already exists. |
|
Strange. Seems this was added since i created my feature. The file, that I added is correct. |
added 10 commits
February 8, 2022 23:43
Signed-off-by: urmet0 <hannes.spenger@gmail.com>
Signed-off-by: urmet0 <hannes.spenger@gmail.com>
Signed-off-by: urmet0 <hannes.spenger@gmail.com>
Signed-off-by: urmet0 <hannes.spenger@gmail.com>
Signed-off-by: urmet0 <hannes.spenger@gmail.com>
Signed-off-by: urmet0 <hannes.spenger@gmail.com>
Signed-off-by: urmet0 <hannes.spenger@gmail.com>
Signed-off-by: urmet0 <hannes.spenger@gmail.com>
Signed-off-by: urmet0 <hannes.spenger@gmail.com>
|
I am trying to get this fixed. |
Signed-off-by: urmet0 <hannes.spenger@gmail.com>
urmet0
force-pushed
the
feature/ohmpilot
branch
from
0838c40 to
45d03b7
Compare
|
@lolodomo big thanks for doing the review! |
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
…er (openhab#11835) * Added support for fronius ohmpilot and added smart meter power sum. Signed-off-by: urmet0 <hannes.spenger@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
…er (openhab#11835) * Added support for fronius ohmpilot and added smart meter power sum. Signed-off-by: urmet0 <hannes.spenger@gmail.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…er (openhab#11835) * Added support for fronius ohmpilot and added smart meter power sum. Signed-off-by: urmet0 <hannes.spenger@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…er (openhab#11835) * Added support for fronius ohmpilot and added smart meter power sum. Signed-off-by: urmet0 <hannes.spenger@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…er (openhab#11835) * Added support for fronius ohmpilot and added smart meter power sum. Signed-off-by: urmet0 <hannes.spenger@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two things: