[opensprinkler] Add Veto and some default times to state options. #11816

Skinah · 2021-12-19T02:38:46Z

PR does two things.

Gives default times to the duration channels so a new OH3 user does not need to setup metadata for the state options to get a working list widget.
Adds Veto to the autoUpdates on a single channel as it was causing issues with a user here on the forum. closes [opensprinkler] Sequencing station commands can lead to unexpected behaviour unless autoupdate='false' #11815

Signed-off-by: Matthew Skinner matt@pcmus.com

lolodomo · 2021-12-19T09:39:42Z

bundles/org.openhab.binding.opensprinkler/src/main/resources/OH-INF/thing/thing-types.xml

+		<state readOnly="false" pattern="%.0f min">
+			<options>
+				<option value="15s">15 Seconds</option>
+				<option value="1min">1 Minute</option>
+				<option value="5min">5 Minutes</option>


Do your options cover all possible values or only few of them ?
Is the pattern still necessary ? For other values ?
I have a doubt about the values in your options with different units. What unit is used when building the channel state in the binding.
Is it something you tested ?
Same comments for the other channel (rainDelay).

Covers values that most users should be happy with. Metadata can be added to change these default values if they do not suit and I have tested doing this. The issue IMHO is when no defaults are provided the control/widgets default to ANALIZE and showing a graph instead of offering a list of suitable commands to send. For a new openHAB user these changes are far better and also saves time for experienced users if the defaults are suitable.

RE pattern: I have removed it for the nextDuration as the pattern was not necessary. For the rainDelay channel the API uses hours so I would prefer this gets displayed by default so if people see the TRACE logs they are less likely to get confused. Users can over ride the pattern with metadata. Originally when the binding was merged the ANALIZE feature did not take UOM into account when stored in persistence and this worked around that, not sure if this is fixed now in newer openHAB cores as I have seen it mentioned a few times.

The rainDelay has a state that the API will count down in hours. The code does handle all the different units and this is something I have tested for 10+ months now as I have been using Metadata to add the options in different units.

I have never played with Number:Time but if you set 24 hours as value, your final value as a string will be 1d and not 24h ?

And for the other channel, are you sure you will get 1min rather than 60s for example?

All I know is that I have tested it, and it works as I don't know how the UOM works in depth internally. When the command is sent, the device is queried and the response back from the device updates the channels state in HOURS as per the pattern. The channel that has had the pattern removed can at times display the result in seconds if for example a time of 4 days is selected it can change to be shown in seconds. Most of the time it displays the selected option as the nextDuration, as the device does not have a state for this. It is only a virtual control used when you turn a watering zone on.

I am not clear with that. Can another maintainer please comment & review? @fwolter @cweitkamp @wborn @kaikreuzer

I've never tested if a StringType sent to a Channel, defined in state options and the Channel linked to an UoM Item converts correctly when the string is suffixed with the unit. There's a QuantityType constructor that accepts strings in the format defined in above state options. I think it can work and I trust in @Skinah if he says he tested it, that it works.

In this case, if you think this is ok, please merge this PR @fwolter

lolodomo · 2021-12-19T09:42:42Z

And please also run the maven command to update the default i18n properties file.

mvn i18n:generate-default-translations

Skinah · 2021-12-20T05:04:54Z

I tried to run mvn i18n:generate-default-translations guessing the build system is not yet ready for building 3.3.0-SNAPSHOT?

I got these lines...

[WARNING] The POM for org.openhab.core.tools:i18n-maven-plugin:jar:3.3.0-SNAPSHOT is missing, no dependency information available

.....

[ERROR] No plugin found for prefix 'i18n' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (C:\Users\nospa\.m2\repository), central (https://repo1.maven.org/maven2), openhab-release (https://openhab.jfrog.io/openhab/libs-release)] -> [Help 1]

.......

lolodomo · 2021-12-20T19:14:52Z

Build failed. Please apply spotless: mvn spotless:apply

lolodomo · 2021-12-20T19:56:11Z

A soon as you fixed the spotless problem, I will run the i18n tool for you and create a PR to your repo.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

Skinah · 2021-12-21T00:24:29Z

Spotless was fine on my system, so I did another rebase and force push and now it shows as sorted.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

lolodomo · 2021-12-21T20:09:37Z

@Skinah : I pushed a PR to your repo with the result of the run of the i18n translation tool.

Update default translations properties Signed-off-by: Matthew Skinner <matt@pcmus.com>

Skinah · 2021-12-23T01:42:39Z

thanks, changes have been merged.

lolodomo · 2022-01-07T21:50:30Z

@fwolter : please take the lead to review this PR

…enhab#11816) * Add default times to state options. Signed-off-by: Matthew Skinner <matt@pcmus.com> * remove pattern Signed-off-by: Matthew Skinner <matt@pcmus.com> * Update default translations properties Signed-off-by: Laurent Garnier <lg.hc@free.fr> Co-authored-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>

…enhab#11816) * Add default times to state options. Signed-off-by: Matthew Skinner <matt@pcmus.com> * remove pattern Signed-off-by: Matthew Skinner <matt@pcmus.com> * Update default translations properties Signed-off-by: Laurent Garnier <lg.hc@free.fr> Co-authored-by: Laurent Garnier <lg.hc@free.fr>

…enhab#11816) * Add default times to state options. Signed-off-by: Matthew Skinner <matt@pcmus.com> * remove pattern Signed-off-by: Matthew Skinner <matt@pcmus.com> * Update default translations properties Signed-off-by: Laurent Garnier <lg.hc@free.fr> Co-authored-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Nick Waterton <n.waterton@outlook.com>

openhab-bot · 2022-07-10T11:54:21Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/opensprinkler-binding-how-to-set-nextduration-basic-ui-senscommand-jython/101423/24

…enhab#11816) * Add default times to state options. Signed-off-by: Matthew Skinner <matt@pcmus.com> * remove pattern Signed-off-by: Matthew Skinner <matt@pcmus.com> * Update default translations properties Signed-off-by: Laurent Garnier <lg.hc@free.fr> Co-authored-by: Laurent Garnier <lg.hc@free.fr>

…enhab#11816) * Add default times to state options. Signed-off-by: Matthew Skinner <matt@pcmus.com> * remove pattern Signed-off-by: Matthew Skinner <matt@pcmus.com> * Update default translations properties Signed-off-by: Laurent Garnier <lg.hc@free.fr> Co-authored-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

Skinah added the enhancement An enhancement or new feature for an existing add-on label Dec 19, 2021

Skinah requested review from CrackerStealth and FlorianSW as code owners December 19, 2021 02:38

Skinah changed the title ~~[opensprinkler] Add some default times to state options.~~ [opensprinkler] Add Veto and some default times to state options. Dec 19, 2021

lolodomo reviewed Dec 19, 2021

View reviewed changes

Skinah force-pushed the opensprinkler branch from 55149f1 to 6c39281 Compare December 20, 2021 04:56

Skinah added 2 commits December 21, 2021 10:22

Add default times to state options.

0ea29cf

Signed-off-by: Matthew Skinner <matt@pcmus.com>

remove pattern

7d258c8

Signed-off-by: Matthew Skinner <matt@pcmus.com>

Skinah force-pushed the opensprinkler branch from 79f14e2 to 7d258c8 Compare December 20, 2021 23:23

Update default translations properties

1073593

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

Merge pull request #2 from lolodomo/opensprinkler_i18n

84bfc86

Update default translations properties Signed-off-by: Matthew Skinner <matt@pcmus.com>

fwolter approved these changes Jan 8, 2022

View reviewed changes

fwolter merged commit 06576fa into openhab:main Jan 8, 2022

fwolter added this to the 3.3 milestone Jan 8, 2022

jlaur mentioned this pull request Jul 22, 2022

[OpenSprinkler] station next_duration broken after upgrade #13160

Closed

Skinah deleted the opensprinkler branch October 24, 2022 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[opensprinkler] Add Veto and some default times to state options. #11816

[opensprinkler] Add Veto and some default times to state options. #11816

Skinah commented Dec 19, 2021

lolodomo Dec 19, 2021

Skinah Dec 20, 2021

lolodomo Dec 21, 2021

Skinah Dec 23, 2021 •

edited

Loading

lolodomo Dec 23, 2021

fwolter Dec 27, 2021

lolodomo Dec 28, 2021 •

edited

Loading

lolodomo commented Dec 19, 2021 •

edited

Loading

Skinah commented Dec 20, 2021

lolodomo commented Dec 20, 2021

lolodomo commented Dec 20, 2021

Skinah commented Dec 21, 2021

lolodomo commented Dec 21, 2021

Skinah commented Dec 23, 2021

lolodomo commented Jan 7, 2022

openhab-bot commented Jul 10, 2022

[opensprinkler] Add Veto and some default times to state options. #11816

[opensprinkler] Add Veto and some default times to state options. #11816

Conversation

Skinah commented Dec 19, 2021

lolodomo Dec 19, 2021

Choose a reason for hiding this comment

Skinah Dec 20, 2021

Choose a reason for hiding this comment

lolodomo Dec 21, 2021

Choose a reason for hiding this comment

Skinah Dec 23, 2021 • edited Loading

Choose a reason for hiding this comment

lolodomo Dec 23, 2021

Choose a reason for hiding this comment

fwolter Dec 27, 2021

Choose a reason for hiding this comment

lolodomo Dec 28, 2021 • edited Loading

Choose a reason for hiding this comment

lolodomo commented Dec 19, 2021 • edited Loading

Skinah commented Dec 20, 2021

lolodomo commented Dec 20, 2021

lolodomo commented Dec 20, 2021

Skinah commented Dec 21, 2021

lolodomo commented Dec 21, 2021

Skinah commented Dec 23, 2021

lolodomo commented Jan 7, 2022

openhab-bot commented Jul 10, 2022

Skinah Dec 23, 2021 •

edited

Loading

lolodomo Dec 28, 2021 •

edited

Loading

lolodomo commented Dec 19, 2021 •

edited

Loading