-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miio] Support sending openclose commands #11581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcelrv
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Nov 12, 2021
lolodomo
requested changes
Nov 14, 2021
...b.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoBasicHandler.java
Outdated
Show resolved
Hide resolved
...b.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoBasicHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
lolodomo
approved these changes
Nov 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wborn
changed the title
[miio] support sending openclose commands
[miio] Support sending openclose commands
Dec 18, 2021
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* [miio] support sending openclose commands Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] fix contact sending Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] switch Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
* [miio] support sending openclose commands Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] fix contact sending Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] switch Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* [miio] support sending openclose commands Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] fix contact sending Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] switch Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [miio] support sending openclose commands Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] fix contact sending Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] switch Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [miio] support sending openclose commands Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] fix contact sending Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] switch Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note. Depending on the device, openclose to be send as number or on/off
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com