Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] Support sending openclose commands #11581

Merged
merged 3 commits into from
Nov 14, 2021

Conversation

marcelrv
Copy link
Contributor

Note. Depending on the device, openclose to be send as number or on/off
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv requested a review from kaikreuzer November 12, 2021 22:35
@marcelrv marcelrv added the enhancement An enhancement or new feature for an existing add-on label Nov 12, 2021
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 4d8c6b3 into openhab:main Nov 14, 2021
@lolodomo lolodomo added this to the 3.2 milestone Nov 14, 2021
@marcelrv marcelrv deleted the miio-openclose branch November 21, 2021 15:11
@wborn wborn changed the title [miio] support sending openclose commands [miio] Support sending openclose commands Dec 18, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
* [miio] support sending openclose commands

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] fix contact sending

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] switch

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
* [miio] support sending openclose commands

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] fix contact sending

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] switch

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
* [miio] support sending openclose commands

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] fix contact sending

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] switch

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* [miio] support sending openclose commands

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] fix contact sending

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] switch

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* [miio] support sending openclose commands

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] fix contact sending

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] switch

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants