[pjlinkdevice] Fix authentication #11472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
nils
force-pushed
the
pjlink-authentication-fix
branch
from
6ef53df to
ceaebbd
Compare
lolodomo
added
additional testing preferred
|
@nils : do you prefer waiting for a user feedback or are you enough confident and I merge your change now? |
|
@lolodomo I have confirmed and subsequently fixed the issue using the official PJLink test tool, so it seems to be fine to be merged right away. By the way, do you know what's going on with the PR build artifacts? In the PR description template, there's a path on jfrog mentioned, but that pattern does not seem to work. |
lolodomo
removed
the
additional testing preferred
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
jpg0
pushed a commit
to jpg0/openhab-addons
that referenced
this pull request
Nov 10, 2021
Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
wborn
changed the title
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes authentication problems that have been reported by itseogo on the OpenHAB Community.
The problem was caused by an earlier compatibility fix that generally uppercased responses from the projector. This should not be done for the authentication nonce (which contains lowercase characters that have to be preserved).
The JAR should be available soon.
Here I guess (needs to be validated after the build).