-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homekit] Add support for group item type to window covering #10936
[homekit] Add support for group item type to window covering #10936
Conversation
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/homekit-support-for-rollershutter-group-item/123207/2 |
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type Closes openhab#10812 Signed-off-by: Colin Keehan <github@colin.xyz>
4fcc24f
to
7925e48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for fixing it
looks good for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type Closes openhab#10812 Signed-off-by: Colin Keehan <github@colin.xyz> Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type Closes openhab#10812 Signed-off-by: Colin Keehan <github@colin.xyz> Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type Closes openhab#10812 Signed-off-by: Colin Keehan <github@colin.xyz>
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type Closes openhab#10812 Signed-off-by: Colin Keehan <github@colin.xyz>
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type Closes openhab#10812 Signed-off-by: Colin Keehan <github@colin.xyz>
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type
Closes #10812
Signed-off-by: Colin Keehan github@colin.xyz