Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miio] fix discovery issue for devices with dot in ID #10880

Merged
merged 1 commit into from
Jun 20, 2021
Merged

[miio] fix discovery issue for devices with dot in ID #10880

merged 1 commit into from
Jun 20, 2021

Conversation

marcelrv
Copy link
Contributor

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

avoid error

18:19:51.732 [ERROR] [internal.DiscoveryServiceRegistryImpl] - Cannot trigger scan for thing types '[miio:vacuum, miio:unsupported, miio:basic, miio:generic]' on 'MiIoDiscovery'!
java.lang.IllegalArgumentException: ID segment 'lumi.158d0001e09bdb' contains invalid characters. Each segment of the ID must match the pattern [\w-]*.
        at org.openhab.core.common.AbstractUID.validateSegment(AbstractUID.java:98) ~[?:?]
        at org.openhab.core.common.AbstractUID.<init>(AbstractUID.java:76) ~[?:?]
        at org.openhab.core.common.AbstractUID.<init>(AbstractUID.java:59) ~[?:?]
        at org.openhab.core.thing.UID.<init>(UID.java:57) ~[?:?]
        at org.openhab.core.thing.ThingUID.<init>(ThingUID.java:47) ~[?:?]
        at org.openhab.binding.miio.internal.discovery.MiIoDiscovery.submitDiscovery(MiIoDiscovery.java:236) ~[?:?]
        at org.openhab.binding.miio.internal.discovery.MiIoDiscovery.cloudDiscovery(MiIoDiscovery.java:201) ~[?:?]
        at org.openhab.binding.miio.internal.discovery.MiIoDiscovery.startScan(MiIoDiscovery.java:158) ~[?:?]

@marcelrv
[miio] fix discovery issue when for devices with dot
5fc1a2d 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv added the bug An unexpected problem or unintended behavior of an add-on label Jun 18, 2021
@marcelrv marcelrv requested a review from kaikreuzer June 18, 2021 18:34
@marcelrv marcelrv changed the title [miio] fix discovery issue when for devices with dot [miio] fix discovery issue for devices with dot in ID Jun 18, 2021
@marcelrv marcelrv requested review from fwolter and removed request for kaikreuzer June 19, 2021 17:38
@martinvw martinvw added this to the 3.1 milestone Jun 20, 2021
@martinvw martinvw merged commit 8d39e5b into openhab:main Jun 20, 2021
@marcelrv marcelrv deleted the miio-discovery branch June 20, 2021 20:16
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@marcelrv @computergeek1507
[miio] fix discovery issue when for devices with dot (openhab#10880)
40f0003 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
@marcelrv @lucacalcaterra
[miio] fix discovery issue when for devices with dot (openhab#10880)
3630d39 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
@marcelrv @lucacalcaterra
[miio] fix discovery issue when for devices with dot (openhab#10880)
2ef7fc9 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
@marcelrv @lucacalcaterra
[miio] fix discovery issue when for devices with dot (openhab#10880)
e93cab2 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@marcelrv @frederictobiasc
[miio] fix discovery issue when for devices with dot (openhab#10880)
76261ba 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@marcelrv @thinkingstone
[miio] fix discovery issue when for devices with dot (openhab#10880)
f0e9c7f 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@marcelrv
[miio] fix discovery issue when for devices with dot (openhab#10880)
fe0fdb8 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvw martinvw martinvw approved these changes

@fwolter fwolter Awaiting requested review from fwolter

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelrv @martinvw