[rfxcom] Add firmware type, avoid crashing on unknown. #10879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New firmware type reported from the community that's not in the SDK. Also, we don't actually _use_ the firmware type or device type for anything, so lets not crash if we don't match the bytes - lets just flag it unknown. https://community.openhab.org/t/rfxcom-binding-unsupported-value/123615/12 Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Jamstah
force-pushed
the
interface-unknowns
branch
from
951c460 to
7e64690
Compare
martinvw
approved these changes
Jun 18, 2021
martinvw
added
rebuild
martinvw
added
the
enhancement
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
New firmware type reported from the community that's not in the SDK. Also, we don't actually _use_ the firmware type or device type for anything, so lets not crash if we don't match the bytes - lets just flag it unknown. https://community.openhab.org/t/rfxcom-binding-unsupported-value/123615/12 Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
New firmware type reported from the community that's not in the SDK. Also, we don't actually _use_ the firmware type or device type for anything, so lets not crash if we don't match the bytes - lets just flag it unknown. https://community.openhab.org/t/rfxcom-binding-unsupported-value/123615/12 Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
New firmware type reported from the community that's not in the SDK. Also, we don't actually _use_ the firmware type or device type for anything, so lets not crash if we don't match the bytes - lets just flag it unknown. https://community.openhab.org/t/rfxcom-binding-unsupported-value/123615/12 Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Aug 3, 2021
New firmware type reported from the community that's not in the SDK. Also, we don't actually _use_ the firmware type or device type for anything, so lets not crash if we don't match the bytes - lets just flag it unknown. https://community.openhab.org/t/rfxcom-binding-unsupported-value/123615/12 Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
New firmware type reported from the community that's not in the SDK. Also, we don't actually _use_ the firmware type or device type for anything, so lets not crash if we don't match the bytes - lets just flag it unknown. https://community.openhab.org/t/rfxcom-binding-unsupported-value/123615/12 Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
New firmware type reported from the community that's not in the SDK. Also, we don't actually _use_ the firmware type or device type for anything, so lets not crash if we don't match the bytes - lets just flag it unknown. https://community.openhab.org/t/rfxcom-binding-unsupported-value/123615/12 Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
New firmware type reported from the community that's not in the SDK. Also, we don't actually _use_ the firmware type or device type for anything, so lets not crash if we don't match the bytes - lets just flag it unknown. https://community.openhab.org/t/rfxcom-binding-unsupported-value/123615/12 Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New firmware type reported from the community that's not in the SDK. Also,
we don't actually use the firmware type or device type for anything, so
lets not crash if we don't match the bytes - lets just flag it unknown.
https://community.openhab.org/t/rfxcom-binding-unsupported-value/123615/12
Signed-off-by: James Hewitt james.hewitt@uk.ibm.com