-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[remoteopenhab] Avoid registering conflicting filters for SSE connection #10870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
bruestel
reviewed
Jun 15, 2021
...b/src/main/java/org/openhab/binding/remoteopenhab/internal/rest/RemoteopenhabRestClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
bruestel
approved these changes
Jun 16, 2021
@fwolter : can you please merge this fix, this is the same that was recently merged for the Home Connect binding. |
lolodomo
added
rebuild
Triggers Jenkins PR build
and removed
rebuild
Triggers Jenkins PR build
labels
Jun 20, 2021
fwolter
approved these changes
Jun 20, 2021
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
…ion (openhab#10870) * [remoteopenhab] Avoid registering conflicting filters for SSE connection Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Remove default constructor Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Review comment: declare the hostname verifier in a variable Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
…ion (openhab#10870) * [remoteopenhab] Avoid registering conflicting filters for SSE connection Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Remove default constructor Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Review comment: declare the hostname verifier in a variable Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
…ion (openhab#10870) * [remoteopenhab] Avoid registering conflicting filters for SSE connection Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Remove default constructor Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Review comment: declare the hostname verifier in a variable Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Aug 3, 2021
…ion (openhab#10870) * [remoteopenhab] Avoid registering conflicting filters for SSE connection Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Remove default constructor Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Review comment: declare the hostname verifier in a variable Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
…ion (openhab#10870) * [remoteopenhab] Avoid registering conflicting filters for SSE connection Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Remove default constructor Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Review comment: declare the hostname verifier in a variable Signed-off-by: Laurent Garnier <lg.hc@free.fr>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…ion (openhab#10870) * [remoteopenhab] Avoid registering conflicting filters for SSE connection Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Remove default constructor Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Review comment: declare the hostname verifier in a variable Signed-off-by: Laurent Garnier <lg.hc@free.fr>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…ion (openhab#10870) * [remoteopenhab] Avoid registering conflicting filters for SSE connection Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Remove default constructor Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Review comment: declare the hostname verifier in a variable Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier lg.hc@free.fr