Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rfxcom] Convert unsigned byte to int properly #10830

Merged
merged 1 commit into from
Jun 10, 2021
Merged

[rfxcom] Convert unsigned byte to int properly #10830

merged 1 commit into from
Jun 10, 2021

Conversation

Jamstah
Copy link
Contributor

@Jamstah Jamstah commented Jun 8, 2021

Without this, any message over 127 bytes reports a negative length and
fails the message start test, which puts the code out of sync with the
rfxcom leading to lots of errors, and eventually, complete loss of
connection.

Signed-off-by: James Hewitt james.hewitt@uk.ibm.com

@Jamstah
[rfxcom] Convert unsigned byte to int properly for message length
1fe3fb8 
Without this, any message over 127 bytes reports a negative length and
fails the message start test, which puts the code out of sync with the
rfxcom leading to lots of errors, and eventually, complete loss of
connection.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
@Jamstah Jamstah force-pushed the message-length-fix branch from ed2b47a to 1fe3fb8 Compare June 8, 2021 22:39
martinvw
martinvw approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@martinvw martinvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks

@Jamstah
Copy link
Contributor Author

Jamstah commented Jun 9, 2021

Hey Martin, nice to see you're still on the project :)

Do I need to do anything about the failing tests in another binding?

I've got a few rfxcom changes queued and coming your way :)

@martinvw martinvw added the rebuild Triggers Jenkins PR build label Jun 9, 2021
@martinvw
Copy link
Member

martinvw commented Jun 9, 2021

Hey Martin, nice to see you're still on the project :)

I only focus a bit on HEOS and RFXCom PR's and sometimes a small PR, I'm very busy with work and live in general :-)

Do I need to do anything about the failing tests in another binding?

I triggered a rebuild, let's see how it goes.

@martinvw martinvw removed the rebuild Triggers Jenkins PR build label Jun 9, 2021
@martinvw martinvw merged commit c12e189 into openhab:main Jun 10, 2021
@martinvw martinvw added the enhancement An enhancement or new feature for an existing add-on label Jun 10, 2021
@martinvw martinvw added this to the 3.1 milestone Jun 10, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@Jamstah @computergeek1507
[rfxcom] Convert unsigned byte to int properly for message length (op…
a971c4e 
…enhab#10830)

Without this, any message over 127 bytes reports a negative length and
fails the message start test, which puts the code out of sync with the
rfxcom leading to lots of errors, and eventually, complete loss of
connection.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
@Jamstah @lucacalcaterra
[rfxcom] Convert unsigned byte to int properly for message length (op…
1e9c884 
…enhab#10830)

Without this, any message over 127 bytes reports a negative length and
fails the message start test, which puts the code out of sync with the
rfxcom leading to lots of errors, and eventually, complete loss of
connection.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
@Jamstah @lucacalcaterra
[rfxcom] Convert unsigned byte to int properly for message length (op…
4de367f 
…enhab#10830)

Without this, any message over 127 bytes reports a negative length and
fails the message start test, which puts the code out of sync with the
rfxcom leading to lots of errors, and eventually, complete loss of
connection.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
@Jamstah @lucacalcaterra
[rfxcom] Convert unsigned byte to int properly for message length (op…
ec14dd9 
…enhab#10830)

Without this, any message over 127 bytes reports a negative length and
fails the message start test, which puts the code out of sync with the
rfxcom leading to lots of errors, and eventually, complete loss of
connection.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@Jamstah @frederictobiasc
[rfxcom] Convert unsigned byte to int properly for message length (op…
a9b8696 
…enhab#10830)

Without this, any message over 127 bytes reports a negative length and
fails the message start test, which puts the code out of sync with the
rfxcom leading to lots of errors, and eventually, complete loss of
connection.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@Jamstah @thinkingstone
[rfxcom] Convert unsigned byte to int properly for message length (op…
592805b 
…enhab#10830)

Without this, any message over 127 bytes reports a negative length and
fails the message start test, which puts the code out of sync with the
rfxcom leading to lots of errors, and eventually, complete loss of
connection.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@Jamstah
[rfxcom] Convert unsigned byte to int properly for message length (op…
939c7be 
…enhab#10830)

Without this, any message over 127 bytes reports a negative length and
fails the message start test, which puts the code out of sync with the
rfxcom leading to lots of errors, and eventually, complete loss of
connection.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvw martinvw martinvw approved these changes

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Jamstah @martinvw