Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shelly] Vibration event for DW2 #10618

Merged
merged 5 commits into from
May 9, 2021
Merged

[shelly] Vibration event for DW2 #10618

merged 5 commits into from
May 9, 2021

Conversation

markus7017
Copy link
Contributor

The PR includes

@markus7017
Adapted to new checkstyle
7fa6f1d 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
stylecheck cnages; fix CoIoT update for vibration, url encode user+pw on
6db0a33 
"set login credentials"

Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
openhab#10617 Vibration event added for DW2
788b93f 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 self-assigned this Apr 29, 2021
@markus7017 markus7017 added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged labels Apr 29, 2021
@markus7017 markus7017 added this to the 3.1 milestone Apr 29, 2021
@markus7017 markus7017 linked an issue Apr 29, 2021 that may be closed by this pull request
[shelly] Vibration Event for DW2 #10617
Closed
@markus7017
Copy link
Contributor Author

tested & confirmed by the community

@markus7017 markus7017 removed the work in progress A PR that is not yet ready to be merged label Apr 30, 2021
@markus7017 markus7017 requested a review from fwolter April 30, 2021 05:46
@markus7017
brackets
03c1f2c 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@wborn wborn changed the title [shelly| Vibration event for DW2, [shelly] Vibration event for DW2, May 1, 2021
@wborn wborn changed the title [shelly] Vibration event for DW2, [shelly] Vibration event for DW2 May 1, 2021
@markus7017 markus7017 requested a review from kaikreuzer May 6, 2021 21:25
@markus7017
some unused stuff/code removed
d1957ad 
Signed-off-by: Markus Michels <markus7017@gmail.com>
fwolter
fwolter approved these changes May 9, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks also for fixing the warnings!

@fwolter fwolter merged commit a2084e7 into openhab:main May 9, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@markus7017 @themillhousegroup
[shelly] Vibration event for DW2 (openhab#10618)
e386725 
* Adapted to new checkstyle

Signed-off-by: Markus Michels <markus7017@gmail.com>

* stylecheck cnages; fix CoIoT update for vibration, url encode user+pw on
"set login credentials"

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10617 Vibration event added for DW2

Signed-off-by: Markus Michels <markus7017@gmail.com>

* brackets

Signed-off-by: Markus Michels <markus7017@gmail.com>

* some unused stuff/code removed

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
@markus7017 markus7017 deleted the shelly_snapshot3.1.5 branch May 11, 2021 05:20
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@markus7017 @computergeek1507
[shelly] Vibration event for DW2 (openhab#10618)
12ce34c 
* Adapted to new checkstyle

Signed-off-by: Markus Michels <markus7017@gmail.com>

* stylecheck cnages; fix CoIoT update for vibration, url encode user+pw on
"set login credentials"

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10617 Vibration event added for DW2

Signed-off-by: Markus Michels <markus7017@gmail.com>

* brackets

Signed-off-by: Markus Michels <markus7017@gmail.com>

* some unused stuff/code removed

Signed-off-by: Markus Michels <markus7017@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@markus7017 @frederictobiasc
[shelly] Vibration event for DW2 (openhab#10618)
b8ac065 
* Adapted to new checkstyle

Signed-off-by: Markus Michels <markus7017@gmail.com>

* stylecheck cnages; fix CoIoT update for vibration, url encode user+pw on
"set login credentials"

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10617 Vibration event added for DW2

Signed-off-by: Markus Michels <markus7017@gmail.com>

* brackets

Signed-off-by: Markus Michels <markus7017@gmail.com>

* some unused stuff/code removed

Signed-off-by: Markus Michels <markus7017@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@markus7017 @thinkingstone
[shelly] Vibration event for DW2 (openhab#10618)
004fe59 
* Adapted to new checkstyle

Signed-off-by: Markus Michels <markus7017@gmail.com>

* stylecheck cnages; fix CoIoT update for vibration, url encode user+pw on
"set login credentials"

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10617 Vibration event added for DW2

Signed-off-by: Markus Michels <markus7017@gmail.com>

* brackets

Signed-off-by: Markus Michels <markus7017@gmail.com>

* some unused stuff/code removed

Signed-off-by: Markus Michels <markus7017@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@markus7017
[shelly] Vibration event for DW2 (openhab#10618)
e17cc9e 
* Adapted to new checkstyle

Signed-off-by: Markus Michels <markus7017@gmail.com>

* stylecheck cnages; fix CoIoT update for vibration, url encode user+pw on
"set login credentials"

Signed-off-by: Markus Michels <markus7017@gmail.com>

* openhab#10617 Vibration event added for DW2

Signed-off-by: Markus Michels <markus7017@gmail.com>

* brackets

Signed-off-by: Markus Michels <markus7017@gmail.com>

* some unused stuff/code removed

Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer

Assignees

@markus7017 markus7017

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[shelly] Vibration Event for DW2
2 participants
@markus7017 @fwolter