Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hue] Changed default color mode for color commands to XY #10608

Merged
merged 2 commits into from
May 9, 2021

Conversation

cweitkamp
Copy link
Contributor

  • Changed default color mode for color commands to XY

Fixes #10159

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

@cweitkamp cweitkamp added the bug An unexpected problem or unintended behavior of an add-on label Apr 28, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp force-pushed the bugfix-10159-hue-colormode branch from 7e1e7f7 to 809a211 Compare April 28, 2021 12:51
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an ultra minor typo in a comment.
Was this change validated with official hue color lights ?

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp
Copy link
Contributor Author

Was this change validated with official hue color lights ?

Yes. I am running this for couple of days in my environment and it is working nice. You can find some links to Hue API docs to clarify on the change in #10159 (comment).

@lolodomo
Copy link
Contributor

lolodomo commented May 4, 2021

I am confident on you ;) I will let you know if I encounter problem once it is merged.

@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels May 4, 2021
@cweitkamp cweitkamp requested a review from a team May 5, 2021 19:29
@fwolter fwolter merged commit ea4315a into openhab:main May 9, 2021
@fwolter fwolter added this to the 3.1 milestone May 9, 2021
@cweitkamp cweitkamp deleted the bugfix-10159-hue-colormode branch May 9, 2021 19:12
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
)

* Changed default color mode for color commands to XY

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* Incorporated comments from review

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
)

* Changed default color mode for color commands to XY

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* Incorporated comments from review

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
)

* Changed default color mode for color commands to XY

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* Incorporated comments from review

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
)

* Changed default color mode for color commands to XY

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* Incorporated comments from review

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
)

* Changed default color mode for color commands to XY

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

* Incorporated comments from review

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hue] [zigbee] openhab does not change color on a bulb or zone, if the bulb or zone is in white mode
4 participants