[shelly] New Shelly Manager (more detailed information, status, integrated firmware upgrade) #10276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
additional information. Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017
added
the
enhancement
|
fyi: We are ready to start review. This Manager has already been hardened, no issues open at the moment |
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
for non-Motion devices fixed; AdvancedUsers.md now refers to Shelly Manager Signed-off-by: Markus Michels <markus7017@gmail.com>
|
@fwolter How do we want to proceed here? I check the option to remove the Actions and Firmware handling from the Manager to reduce the PR size. This would include base code and Overview page, but no device actions. This would reduced the PR size apx. by 500-700 lines of code. Would be an option, but I think doesn't move the needle. Nevertheless, I would be open to do that reducing the backlog. I'm expecting samples of a new device generation next week, which requires integration of a new API (in addition to the existing ones). This will bring additional code so I like to find a way to get as much as possible merged before starting on this enhancement. What could be the best compromise with regards to the backlog on your side? |
|
Do you want to remove the Actions and Firmware handling from the code entirely or only from this PR? If the latter, it makes no difference from my POV. If your are blocked by anything, you can base a PR on another PR and add the "awaiting other PR" label. |
|
@fwolter ok, was just a thought to make it easier for you. What time could I expect for someone to start the review here? |
|
Could be a few days or weeks. |
confuses users running 1.10 beta) Signed-off-by: Markus Michels <markus7017@gmail.com>
-Adapt setting CoIoT Mode (Peer/Multicast) to 1.10, device restart after applying new mode - New Icon for Device Status Refresh - New Action Item for Reset Statistics - per device and globally - New Action Item to trigger the firmware check - per device and globally - New action: Trigger check for firmware update - New action: Enable/Disable WiFi Roadming - New action: Reconnect WiFi (battery sensor devices only) - New action: Enable/Disable WiFi Recovery Mode - New action: Enable/Disable Device Debug Mode, Get Log/Log1 (use only when requested by Allterco support) - ShellyManager.md updated Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
- Ignore inconsistent version string for initial 1.10 releases - removed display of firmware id (there are various formats and it has no value) Signed-off-by: Markus Michels <markus7017@gmail.com>
|
@openhab/add-ons-maintainers Can someone support here and start review of the PR. Otherwise, this will get bigger and bigger while extending functionality and I don't want to create more (multiple PRs in parallel are not easy to handle within the same project) |
kaikreuzer
approved these changes
Mar 31, 2021
Daniel-42
pushed a commit
to Daniel-42/openhab-addons
that referenced
this pull request
Apr 6, 2021
…rated firmware upgrade) (openhab#10276) * This PR brings in the Shelly Manager, check doc/ShellyManager.md for additional information. * Restart Device in Manager when CoIoT Mode has changed * Updated pattern to extract version info (thanks @fwolter), CoIoT warning for non-Motion devices fixed; AdvancedUsers.md now refers to Shelly Manager * Modified message when beta is detected (reference to 1.5.7 release build confuses users running 1.10 beta) * Fix for Enable/Disable AP roaming * Handle button events also in detached mode, README updated * Ignore inconsistent version string for initial 1.10 releases * removed display of firmware id (there are various formats and it has no value) Signed-off-by: Markus Michels <markus7017@gmail.com>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…rated firmware upgrade) (openhab#10276) * This PR brings in the Shelly Manager, check doc/ShellyManager.md for additional information. * Restart Device in Manager when CoIoT Mode has changed * Updated pattern to extract version info (thanks @fwolter), CoIoT warning for non-Motion devices fixed; AdvancedUsers.md now refers to Shelly Manager * Modified message when beta is detected (reference to 1.5.7 release build confuses users running 1.10 beta) * Fix for Enable/Disable AP roaming * Handle button events also in detached mode, README updated * Ignore inconsistent version string for initial 1.10 releases * removed display of firmware id (there are various formats and it has no value) Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
…rated firmware upgrade) (openhab#10276) * This PR brings in the Shelly Manager, check doc/ShellyManager.md for additional information. * Restart Device in Manager when CoIoT Mode has changed * Updated pattern to extract version info (thanks @fwolter), CoIoT warning for non-Motion devices fixed; AdvancedUsers.md now refers to Shelly Manager * Modified message when beta is detected (reference to 1.5.7 release build confuses users running 1.10 beta) * Fix for Enable/Disable AP roaming * Handle button events also in detached mode, README updated * Ignore inconsistent version string for initial 1.10 releases * removed display of firmware id (there are various formats and it has no value) Signed-off-by: Markus Michels <markus7017@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…rated firmware upgrade) (openhab#10276) * This PR brings in the Shelly Manager, check doc/ShellyManager.md for additional information. * Restart Device in Manager when CoIoT Mode has changed * Updated pattern to extract version info (thanks @fwolter), CoIoT warning for non-Motion devices fixed; AdvancedUsers.md now refers to Shelly Manager * Modified message when beta is detected (reference to 1.5.7 release build confuses users running 1.10 beta) * Fix for Enable/Disable AP roaming * Handle button events also in detached mode, README updated * Ignore inconsistent version string for initial 1.10 releases * removed display of firmware id (there are various formats and it has no value) Signed-off-by: Markus Michels <markus7017@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…rated firmware upgrade) (openhab#10276) * This PR brings in the Shelly Manager, check doc/ShellyManager.md for additional information. * Restart Device in Manager when CoIoT Mode has changed * Updated pattern to extract version info (thanks @fwolter), CoIoT warning for non-Motion devices fixed; AdvancedUsers.md now refers to Shelly Manager * Modified message when beta is detected (reference to 1.5.7 release build confuses users running 1.10 beta) * Fix for Enable/Disable AP roaming * Handle button events also in detached mode, README updated * Ignore inconsistent version string for initial 1.10 releases * removed display of firmware id (there are various formats and it has no value) Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the Shelly Manager, check doc/ShellyManager.md