[wled] Fix White LED turns on to max brightness for any RGB changes #10252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Fetzer <kontakt@der-fetzer.de>
Skinah
approved these changes
Mar 12, 2021
Skinah
changed the title
fwolter
approved these changes
Mar 13, 2021
There was a problem hiding this comment.
Thanks for your contribution! LGTM, applying the small patch exception.
You need to sign-off your commits. See https://www.openhab.org/docs/developer/contributing.html#sign-your-work The necessary commands are listed when you click on "Details" at the DCO check below.
|
Just saw that you signed the commit correctly. The check complained because you used a different name in your Git settings. |
arjanmels
pushed a commit
to arjanmels/openhab2-addons
that referenced
this pull request
Mar 14, 2021
Signed-off-by: Matthias Fetzer <kontakt@der-fetzer.de>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
Signed-off-by: Matthias Fetzer <kontakt@der-fetzer.de> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
wborn
changed the title
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
Signed-off-by: Matthias Fetzer <kontakt@der-fetzer.de>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Matthias Fetzer <kontakt@der-fetzer.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Matthias Fetzer <kontakt@der-fetzer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are using WLED with an RGBW strip every time you set a color the white channel is set to maximum brightness.
The source of the problem is the conversion from HSB to RGB that sets the MSB of the resulting int to 0xFF. This is then interpreted as white channel value by WLED.
This PR fixes this problem by zeroing the MSB.