Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miele] Error handling improvements #12496

Closed
jlaur opened this issue Mar 20, 2022 · 0 comments · Fixed by #12497
Closed

[miele] Error handling improvements #12496

jlaur opened this issue Mar 20, 2022 · 0 comments · Fixed by #12497
Assignees
@jlaur
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@jlaur
Copy link
Contributor

jlaur commented Mar 20, 2022 •
edited
Loading

Currently the Miele binding doesn't have null-annotations, which hides some underlying problems like incomplete error handling and risk of NullPointerExceptions.

This issue is placeholder for some planned improvements:

  • Fix all SAT warnings (null-annotate all classes).
  • Introduce exceptions instead of returning null (where it makes sense).
  • Extract DTO classes for deserialization into separate public classes.
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Mar 20, 2022
@jlaur jlaur self-assigned this Mar 20, 2022
jlaur added a commit to jlaur/openhab-addons that referenced this issue Mar 20, 2022
@jlaur
Add null annotations and improve error handling robustness
df65b56 
Fixes openhab#12496

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur mentioned this issue Mar 20, 2022
Merged
wborn pushed a commit that referenced this issue Mar 21, 2022
@jlaur
[miele] Add null annotations and improve error handling robustness (#…
f21bbc5 
…12497)

* Add null annotations and improve error handling robustness
* Fix compliancy with rule ConstantNameCheck

Fixes #12496

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this issue Apr 27, 2022
@jlaur @NickWaterton
[miele] Add null annotations and improve error handling robustness (o…
e4a4bd2 
…penhab#12497)

* Add null annotations and improve error handling robustness
* Fix compliancy with rule ConstantNameCheck

Fixes openhab#12496

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this issue Nov 6, 2022
@jlaur @andan67
[miele] Add null annotations and improve error handling robustness (o…
3a81f7a 
…penhab#12497)

* Add null annotations and improve error handling robustness
* Fix compliancy with rule ConstantNameCheck

Fixes openhab#12496

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this issue Nov 12, 2022
@jlaur @andrasU
[miele] Add null annotations and improve error handling robustness (o…
64181e7 
…penhab#12497)

* Add null annotations and improve error handling robustness
* Fix compliancy with rule ConstantNameCheck

Fixes openhab#12496

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this issue Feb 23, 2023
@jlaur @psmedley
[miele] Add null annotations and improve error handling robustness (o…
8f13d31 
…penhab#12497)

* Add null annotations and improve error handling robustness
* Fix compliancy with rule ConstantNameCheck

Fixes openhab#12496

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlaur jlaur

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[miele] Add null annotations and improve error handling robustness jlaur/openhab-addons
1 participant
@jlaur