Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point cloud #14

Closed
volkercoors opened this issue Sep 9, 2018 · 6 comments
Closed

point cloud #14

volkercoors opened this issue Sep 9, 2018 · 6 comments

Comments

@volkercoors
Copy link

PointCloud is definitely not a Feature. It is a geometrical representation of spatial entities / city objects. The Point Cloud should not be modelled as FeatureType, but as a Geometry. And maybe not as part of the core.

grafik

TatjanaKutzner added a commit to TatjanaKutzner/CityGML-3.0CM that referenced this issue Oct 16, 2018
@TatjanaKutzner
Copy link
Contributor

Based on discussions between Volker and Thomas at the last OGC meeting on whether the PointCloud class should be part of the Core module or not, I modified the UML model now in such a way that the PointCloud class becomes part of an individual PointCloud module.
grafik
commit 8e2715c

@TatjanaKutzner
Copy link
Contributor

In general, I think it is fine to move the class to an individual module.

However, one disadvantage of this representation is that a geometry class needs to be provided again within a thematic class. CityGML 3.0 aims at bundling all geometry classes as far as possible in the Core module, the classes in the thematic modules inheriting the geometries by extending them from the abstract classes in the Core module.

@TatjanaKutzner
Copy link
Contributor

The new PointCloud module introduces a module dependency from the Relief module to the PointCloud module, as the Relief module requires the point cloud concept to represent the mass point relief. We will need a requirement that when the Relief module is used, also the PointCloud module needs to be included.

@clausnagel
Copy link
Member

+1 for moving PointCloud to an optional module. Not sure though why we need a point cloud to model the mass points of a terrain. Does not sound like a natural choice to me. Why not simply use GM_MultiPoint for MassPointRelief like in CityGML 2.0?

@3DXScape
Copy link
Contributor

Does anyone see the need for or anything in what we have done so far that would make it difficult/impossible to use some other geometric representation (e.g. CSG or simplicial complexes) in CityGML 3.0. Is mixing and matching possible?

@clausnagel
Copy link
Member

Resolved in draft release 3.0.0-draft.2018.12.17.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants